Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-05 Thread Linus Walleij
On Wed, Dec 5, 2018 at 3:30 PM Marek Szyprowski wrote: > > I just sent a fix for that, subject: > > "gpio: devres: Handle nonexclusive GPIOs" > > you could perhaps try it on top of this > > series? I intend to merge that separately as a fix for current, > > as it is a bug. > > Those 2 warnings we

Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-05 Thread Marek Szyprowski
Hi Linus, On 2018-12-04 13:44, Linus Walleij wrote: > On Tue, Dec 4, 2018 at 11:33 AM Marek Szyprowski > wrote: > Artik5 evaluation board (arch/arm/boot/dts/exynos3250-artik5-eval.dtb): s2mps11-pmic s2mps14-regulator: Failed to get control GPIO for 11/LDO12 >>> Question: this is suppose

Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-04 Thread Linus Walleij
On Tue, Dec 4, 2018 at 11:33 AM Marek Szyprowski wrote: > >> Artik5 evaluation board (arch/arm/boot/dts/exynos3250-artik5-eval.dtb): > >> s2mps11-pmic s2mps14-regulator: Failed to get control GPIO for 11/LDO12 > > Question: this is supposed to fail, right? It is something > > like a probe deferra

Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-04 Thread Marek Szyprowski
Hi Linus, On 2018-12-04 10:31, Linus Walleij wrote: > Hi Marek, > > first, thanks a *lot* for testing this, it is is much, much appreciated! > > On Mon, Dec 3, 2018 at 3:35 PM Marek Szyprowski > wrote: > >> The idea is good imho, but it looks that there are some missing cases in >> the code. Here

Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-04 Thread Linus Walleij
Hi Marek, first, thanks a *lot* for testing this, it is is much, much appreciated! On Mon, Dec 3, 2018 at 3:35 PM Marek Szyprowski wrote: > The idea is good imho, but it looks that there are some missing cases in > the code. Here are some logs from the boards I have access to: OK let's fix thi

Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-03 Thread Marek Szyprowski
Hi Linus, On 2018-12-01 16:41, Linus Walleij wrote: > Here is a second iteration of these fixups after thinking > over Charles Keepax excellent comments on the first series > of fixes. > > To make sure GPIO descriptors are never left dangling > (as far as I can tell!) I use this stepwise approach:

[PATCH 00/13 v2] Regulator ena_gpiod fixups

2018-12-01 Thread Linus Walleij
Here is a second iteration of these fixups after thinking over Charles Keepax excellent comments on the first series of fixes. To make sure GPIO descriptors are never left dangling (as far as I can tell!) I use this stepwise approach: 1. Fix the regulator_register() in the core to guarantee th