Re: [ckrm-tech] [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-30 Thread Srivatsa Vaddagiri
On Mon, Apr 30, 2007 at 06:23:52PM +0100, Christoph Hellwig wrote: > Umm, no - please naje two versions with and without the lock. Ok this patch may not be necessary (given Paul's observation that read_lock will suffice in update_nodemask). > Also Please fix up the codingstyle, the { belongs onto

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-30 Thread Srivatsa Vaddagiri
On Mon, Apr 30, 2007 at 10:09:38AM -0700, Paul Menage wrote: > Paul, is there any reason why we need to do a write_lock() on > tasklist_lock if we're just trying to block fork, or is it just > historical accident? Wouldn't it be fine to do a read_lock()? Good point ..read_lock() will probably suff

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 10:42:25PM +0530, Srivatsa Vaddagiri wrote: > On Sun, Apr 29, 2007 at 02:37:21AM -0700, Paul Jackson wrote: > > It builds and boots and mounts the cpuset file system ok. > > But trying to write the 'mems' file hangs the system hard. > > Basically we are attempting a read_lo

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-30 Thread Paul Menage
On 4/30/07, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: On Sun, Apr 29, 2007 at 02:37:21AM -0700, Paul Jackson wrote: > It builds and boots and mounts the cpuset file system ok. > But trying to write the 'mems' file hangs the system hard. Basically we are attempting a read_lock(&tasklist_lock)

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-30 Thread Srivatsa Vaddagiri
On Sun, Apr 29, 2007 at 02:37:21AM -0700, Paul Jackson wrote: > It builds and boots and mounts the cpuset file system ok. > But trying to write the 'mems' file hangs the system hard. Basically we are attempting a read_lock(&tasklist_lock) in container_task_count() after taking write_lock_irq(&task

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-29 Thread Paul Jackson
I'm afraid that this patch set doesn't do cpusets very well. It builds and boots and mounts the cpuset file system ok. But trying to write the 'mems' file hangs the system hard. I had to test it against 2.6.21-rc7-mm2, because I can't boot 2.6.21-rc7-mm1, due to the 'bad_page' problem that I note

Re: [PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-28 Thread Paul Jackson
> - decide whether "Containers" is an acceptable name for the system > given its usage by some other development groups, or whether something > else (ProcessSets? ResourceGroups? TaskGroups?) would be better I place in nomination: tasksets However this would conflict with the taskset uti

[PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-27 Thread menage
-- This is an update to my multi-hierarchy multi-subsystem generic process containers patch. Changes since V8 (April 6th) include: - The patchset has been rebased over 2.6.21-rc7-mm1 - The patchset has been restructured based on feedback; more functionality is now split out into separate patch