Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-18 Thread Tetsuo Handa
On 2021/03/18 22:13, Shuah Khan wrote: > Please don't review code that isn't sent upstream. This repo you are > looking at is a private branch created just to verify fixes on syzbot. But nobody was able to review this series when sent to ML (except you simply ignored my questions), and this series

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-18 Thread Shuah Khan
On 3/17/21 9:06 AM, Shuah Khan wrote: On 3/17/21 12:21 AM, Tetsuo Handa wrote: Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. - Fix attach_store() to check usbip_event_happened() before    waking up threads

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-17 Thread Shuah Khan
On 3/17/21 9:38 AM, Tetsuo Handa wrote: On 2021/03/18 0:06, Shuah Khan wrote: Yes. I haven't sent the patch for that reason. I am trying to test a solution. I haven't come up with a solution yet. Holding event_lock isn't the right solution. I am not going to accept that. This is a window that g

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-17 Thread Shuah Khan
On 3/17/21 12:21 AM, Tetsuo Handa wrote: Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. - Fix attach_store() to check usbip_event_happened() before waking up threads. No, this helps nothing. diff --gi

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-17 Thread Tetsuo Handa
On 2021/03/18 0:06, Shuah Khan wrote: > Yes. I haven't sent the patch for that reason. I am trying to test a > solution. I haven't come up with a solution yet. > > Holding event_lock isn't the right solution. I am not going to accept > that. This is a window that gets triggered by syzbot injecting

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-16 Thread Tetsuo Handa
Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. > - Fix attach_store() to check usbip_event_happened() before > waking up threads. No, this helps nothing. > diff --git a/drivers/usb/usbip/vhci_sysfs.c b/driv

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-14 Thread Tetsuo Handa
On 2021/03/13 9:48, Tetsuo Handa wrote: > On 2021/03/12 14:44, Tetsuo Handa wrote: >> And what you are missing in your [PATCH 4,5,6/6] is >> >> diff --git a/drivers/usb/usbip/vhci_sysfs.c >> b/drivers/usb/usbip/vhci_sysfs.c >> index c4457026d5ad..3c64bd06ab53 100644 >> --- a/drivers/usb/usbi

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-12 Thread Tetsuo Handa
On 2021/03/12 14:44, Tetsuo Handa wrote: > And what you are missing in your [PATCH 4,5,6/6] is > > diff --git a/drivers/usb/usbip/vhci_sysfs.c b/drivers/usb/usbip/vhci_sysfs.c > index c4457026d5ad..3c64bd06ab53 100644 > --- a/drivers/usb/usbip/vhci_sysfs.c > +++ b/drivers/usb/usbip/vhci_sy

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-11 Thread Tetsuo Handa
I cloned git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git as you are testing changes there. > commit 09e4522c87ff54c655c09f318a68b012eda8eb01 (HEAD -> usbip_test, > origin/usbip_test) > Author: Shuah Khan > Date: Thu Mar 11 11:18:25 2021 -0700 > >usbip: fix vhci races in conn

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-11 Thread Tetsuo Handa
On 2021/03/11 21:57, Greg KH wrote: > On Thu, Mar 11, 2021 at 09:34:38PM +0900, Tetsuo Handa wrote: >> On 2021/03/11 3:33, Greg KH wrote: >>> On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: This patch series fixes the following problems founds in syzbot fuzzing. >>> >>> Thanks

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 09:34:38PM +0900, Tetsuo Handa wrote: > On 2021/03/11 3:33, Greg KH wrote: > > On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: > >> This patch series fixes the following problems founds in syzbot > >> fuzzing. > > > > Thanks for these, all now queued up. > > I

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-11 Thread Tetsuo Handa
On 2021/03/11 3:33, Greg KH wrote: > On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: >> This patch series fixes the following problems founds in syzbot >> fuzzing. > > Thanks for these, all now queued up. I send SIGSTOP to [PATCH 4/6] usbip: fix stub_dev usbip_sockfd_store() races

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-10 Thread Greg KH
On Sun, Mar 07, 2021 at 08:53:25PM -0700, Shuah Khan wrote: > This patch series fixes the following problems founds in syzbot > fuzzing. Thanks for these, all now queued up. greg k-h

[PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-07 Thread Shuah Khan
This patch series fixes the following problems founds in syzbot fuzzing. 1. The first 3 patches fix usbip-host, vhci_hcd, vudc sub-drivers to validate the passed in file descriptor is a stream socket. If the file descriptor passed was a SOCK_DGRAM socket, sock_recvmsg() can't detect end o