Re: [PATCH 0/5] tpm: tpm_ibmvtpm: - style fix

2017-08-02 Thread Jarkko Sakkinen
On Sat, Jul 29, 2017 at 03:24:28PM +0800, SZ Lin wrote: > Fix styling WARNINGs and Errors of tpm_ibmvtpm.c driver by using checkpatch.pl Changes are great but you should revise the patch series so that you expain in each commit what goes wrong instead of copy paste of the checkpatch output and why

[PATCH 0/5] tpm: tpm_ibmvtpm: - style fix

2017-07-29 Thread SZ Lin
Fix styling WARNINGs and Errors of tpm_ibmvtpm.c driver by using checkpatch.pl SZ Lin (5): Fix packed and aligned attribute warnings. Fix "ERROR: code indent should use tabs where possible" Fix 'void function return statements are not generally useful' warning Remove unneccessary 'out of m