Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-16 Thread Sam Ravnborg
Hi Suraj. On Sat, Jul 11, 2020 at 08:41:26PM +0530, Suraj Upadhyay wrote: > On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > > Hi Suraj. > > > > On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > > > > > This patchset converts logging to drm_* functions in drm cor

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-13 Thread Suraj Upadhyay
On Sun, Jul 12, 2020 at 12:07:45PM -0700, Joe Perches wrote: > On Mon, 2020-07-13 at 00:24 +0530, Suraj Upadhyay wrote: > > On Sat, Jul 11, 2020 at 11:16:33AM -0700, Joe Perches wrote: > [] > > > Perhaps change the __drm_printk macro to not > > > dereference the drm argument when NULL. > > > > > >

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-12 Thread Joe Perches
On Mon, 2020-07-13 at 00:24 +0530, Suraj Upadhyay wrote: > On Sat, Jul 11, 2020 at 11:16:33AM -0700, Joe Perches wrote: [] > > Perhaps change the __drm_printk macro to not > > dereference the drm argument when NULL. > > > > A trivial but perhaps inefficient way might be > > used like: > > > >

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-12 Thread Suraj Upadhyay
On Sat, Jul 11, 2020 at 11:16:33AM -0700, Joe Perches wrote: > On Sat, 2020-07-11 at 20:41 +0530, Suraj Upadhyay wrote: > > On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > > > Hi Suraj. > > > > > > On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > > > This patchse

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-11 Thread Joe Perches
On Sat, 2020-07-11 at 20:41 +0530, Suraj Upadhyay wrote: > On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > > Hi Suraj. > > > > On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > > This patchset converts logging to drm_* functions in drm core. > > > > > > The follo

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-11 Thread Suraj Upadhyay
On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > Hi Suraj. > > On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > > > This patchset converts logging to drm_* functions in drm core. > > > > The following functions have been converted to their respective > > DRM alt

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-10 Thread Sam Ravnborg
Hi Suraj. On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > This patchset converts logging to drm_* functions in drm core. > > The following functions have been converted to their respective > DRM alternatives : > dev_info() --> drm_info() > dev_err() --> drm_err() >

[PATCH 0/4] drm: core: Convert logging to drm_* functions.

2020-07-07 Thread Suraj Upadhyay
This patchset converts logging to drm_* functions in drm core. The following functions have been converted to their respective DRM alternatives : dev_info() --> drm_info() dev_err() --> drm_err() dev_warn() --> drm_warn() dev_err_once() --> drm_err_once(). Suraj Upadhyay (4):