Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-10-15 Thread Christian Borntraeger
Am Montag, 10. September 2007 schrieb Laurent Vivier: > The aim of these four patches is to introduce Virtual Machine time accounting. I would move this line    if (p->flags & PF_VCPU) {    account_guest_time(p, cputime); -->   p->flags &= ~PF_VCPU; <-    

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Rik van Riel
Laurent Vivier wrote: And as values are read with a sscanf() by procps, I think adding a field at the end of the line is not a problem. It's not. At the time iowait was introduced I verified this in procps. -- All Rights Reversed - To unsubscribe from this list: send the line "unsubscribe l

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Rik van Riel
Ingo Molnar wrote: * Laurent Vivier <[EMAIL PROTECTED]> wrote: This new version remove conditional compilation on GUEST_ACCOUNTING. excellent! For all 4 patches: Acked-by: Ingo Molnar <[EMAIL PROTECTED]> i'd suggest inclusion into 2.6.24. can the /proc change break anything? Any old procp

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Laurent Vivier
Ingo Molnar wrote: > * Laurent Vivier <[EMAIL PROTECTED]> wrote: > >> This new version remove conditional compilation on GUEST_ACCOUNTING. > > excellent! For all 4 patches: > > Acked-by: Ingo Molnar <[EMAIL PROTECTED]> > > i'd suggest inclusion into 2.6.24. Thank you. > can the /proc change

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Laurent Vivier
Alistair John Strachan wrote: > On Monday 10 September 2007 14:08:45 Laurent Vivier wrote: >> Avi Kivity wrote: >>> Ingo Molnar wrote: * Laurent Vivier <[EMAIL PROTECTED]> wrote: > Ingo, please, could you have a look to these patches ? > > The aim of these four patches is to introd

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Ingo Molnar
* Laurent Vivier <[EMAIL PROTECTED]> wrote: > This new version remove conditional compilation on GUEST_ACCOUNTING. excellent! For all 4 patches: Acked-by: Ingo Molnar <[EMAIL PROTECTED]> i'd suggest inclusion into 2.6.24. can the /proc change break anything? Any old procps version perhaps?

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Rik van Riel
Laurent Vivier wrote: The aim of these four patches is to introduce Virtual Machine time accounting. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Acked-by: Rik van Riel <[EMAIL PROTECTED]> -- Politics is the struggle between those who want to make their country the best in the world,

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Alistair John Strachan
On Monday 10 September 2007 14:08:45 Laurent Vivier wrote: > Avi Kivity wrote: > > Ingo Molnar wrote: > >> * Laurent Vivier <[EMAIL PROTECTED]> wrote: > >>> Ingo, please, could you have a look to these patches ? > >>> > >>> The aim of these four patches is to introduce Virtual Machine time > >>> ac

[RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Laurent Vivier
This new version remove conditional compilation on GUEST_ACCOUNTING. -- The aim of these four patches is to introduce Virtual Machine time accounting. [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and "system", we need a new field, "guest", in cpustat to store

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Laurent Vivier
Avi Kivity wrote: > Ingo Molnar wrote: >> * Laurent Vivier <[EMAIL PROTECTED]> wrote: >> >> >>> Ingo, please, could you have a look to these patches ? >>> >>> The aim of these four patches is to introduce Virtual Machine time >>> accounting. >>> >>> [PATCH 1/4] as recent CPUs introduce a third ru

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Avi Kivity
Ingo Molnar wrote: * Laurent Vivier <[EMAIL PROTECTED]> wrote: Ingo, please, could you have a look to these patches ? The aim of these four patches is to introduce Virtual Machine time accounting. [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and "system", we

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Laurent Vivier
Ingo Molnar wrote: > * Laurent Vivier <[EMAIL PROTECTED]> wrote: > >> Ingo, please, could you have a look to these patches ? >> >> The aim of these four patches is to introduce Virtual Machine time >> accounting. >> >> [PATCH 1/4] as recent CPUs introduce a third running state, after >> "user" a

Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Ingo Molnar
* Laurent Vivier <[EMAIL PROTECTED]> wrote: > Ingo, please, could you have a look to these patches ? > > The aim of these four patches is to introduce Virtual Machine time > accounting. > > [PATCH 1/4] as recent CPUs introduce a third running state, after > "user" and "system", we need a new

[RESEND][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Laurent Vivier
Ingo, please, could you have a look to these patches ? The aim of these four patches is to introduce Virtual Machine time accounting. [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and "system", we need a new field, "guest", in cpustat to store the time used by the CPU t

Re: [kvm-devel] Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-21 Thread Glauber de Oliveira Costa
On 8/21/07, Christian Borntraeger <[EMAIL PROTECTED]> wrote: > Am Montag, 20. August 2007 schrieb Glauber de Oliveira Costa: > > Although I don't know KVM to a that deep level, I think it should be > > possible to keep the virtual cpus in different process (or threads), > > and take the accounting

Re: Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-21 Thread Glauber de Oliveira Costa
On 8/21/07, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Glauber de Oliveira Costa wrote: > >> by doing this at kernel level, we can: > >> - measure exactly the guest time, > >> - move this part of system time to user time (as you think it should be > >> user time), > >> - have consistency between s

Re: [kvm-devel] [PATCH 0/4] Virtual Machine Time Accounting

2007-08-21 Thread Avi Kivity
Jeremy Fitzhardinge wrote: Laurent Vivier wrote: functionnalities: - allow to measure time spent by a CPU in a virtual CPU. - allow to display in /proc/state this value by CPU - allow to display in /proc//state this value by process - allow KVM to use these 3 previous functionnalities

Re: [kvm-devel] Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-21 Thread Christian Borntraeger
Am Montag, 20. August 2007 schrieb Glauber de Oliveira Costa: > Although I don't know KVM to a that deep level, I think it should be > possible to keep the virtual cpus in different process (or threads), > and take the accounting time from there. Perfectly possible to know > the time we spent runni

Re: Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-21 Thread Laurent Vivier
Glauber de Oliveira Costa wrote: >> by doing this at kernel level, we can: >> - measure exactly the guest time, >> - move this part of system time to user time (as you think it should be >> user time), >> - have consistency between system, user and guest time, >> - report values in /proc/state and

Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Rusty Russell
On Mon, 2007-08-20 at 09:13 -0700, Jeremy Fitzhardinge wrote: > Laurent Vivier wrote: > > functionnalities: > > > > - allow to measure time spent by a CPU in a virtual CPU. > > - allow to display in /proc/state this value by CPU > > - allow to display in /proc//state this value by process > > - all

Re: Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Glauber de Oliveira Costa
> by doing this at kernel level, we can: > - measure exactly the guest time, > - move this part of system time to user time (as you think it should be > user time), > - have consistency between system, user and guest time, > - report values in /proc/state and /proc//state, at system wide level > >

Réf. : Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread laurent . vivier
> Laurent Vivier wrote: > functionnalities: > > > - allow to measure time spent by a CPU in a virtual CPU. > > - allow to display in /proc/state this value by CPU > > - allow to display in /proc//state this value by process > > - allow KVM to use these 3 previous functionnalities > > > > So, curre

Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Jeremy Fitzhardinge
Laurent Vivier wrote: > functionnalities: > > - allow to measure time spent by a CPU in a virtual CPU. > - allow to display in /proc/state this value by CPU > - allow to display in /proc//state this value by process > - allow KVM to use these 3 previous functionnalities > So, currently time spe

Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Laurent Vivier
Hi John, John Stoffel wrote: > > Laurent> The aim of these four patches is to introduce Virtual Machine > Laurent> time accounting. > > So what does this buy us? What increased functionality? > functionnalities: - allow to measure time spent by a CPU in a virtual CPU. - allow to display in

Re: [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread John Stoffel
Laurent> The aim of these four patches is to introduce Virtual Machine Laurent> time accounting. So what does this buy us? What increased functionality? Laurent> [PATCH 1/4] as recent CPUs introduce a third running state, Laurent> after "user" and "system", we need a new field, "guest", in L

Re: [kvm-devel] [PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Avi Kivity
Laurent Vivier wrote: The aim of these four patches is to introduce Virtual Machine time accounting. 1-3 look good to me. 4 needs minor edits... -- error compiling committee.c: too many arguments to function - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[PATCH 0/4] Virtual Machine Time Accounting

2007-08-20 Thread Laurent Vivier
The aim of these four patches is to introduce Virtual Machine time accounting. _Ingo_, as these patches modify files of the scheduler, could you have a look to them, please ? [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and "system", we need a new field, "guest", in cp