[PATCH 0/3] tracing: Fix some selftest issues

2024-06-10 Thread Masami Hiramatsu (Google)
Hi, Here is v2 of a series of some fixes/cleanups for the test modules and boot time selftest of kprobe events. The previous version is here; https://lore.kernel.org/all/171671825710.39694.6859036369216249956.stgit@devnote2/ In this version, I just update the description of the first patch to ad

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-06-10 Thread Steven Rostedt
On Mon, 10 Jun 2024 11:10:01 +0900 Masami Hiramatsu (Google) wrote: > > But you don't explain what exactly the conflict is. What about those > > events causes kprobe selftests to fail? > > I also found another problem on these modules. These modules get trace > event file references to prevent

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-06-09 Thread Google
On Fri, 31 May 2024 03:24:25 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 11:37:21 +0900 > Masami Hiramatsu (Google) wrote: > > > So, in summary, it is designed to be a module. Steve, I think these tests > > should be kept as modules. There are many reason to do so. > > > > - This test i

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-06-04 Thread Steven Rostedt
On Tue, 4 Jun 2024 23:18:29 +0900 Masami Hiramatsu (Google) wrote: > BTW, some these bootup tests can be ported on KUnit. Do you have a plan to > use KUnit? I haven't thought about that. If someone else wants to do it, I will happily review it ;-) -- Steve

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-06-04 Thread Google
On Tue, 4 Jun 2024 09:57:46 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 23:20:47 +0900 > Masami Hiramatsu (Google) wrote: > > > The major conflict happens when the boot-time test cleans up the kprobe > > events by > > > > dyn_events_release_all(&trace_kprobe_ops); > > > > And I remove

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-06-04 Thread Steven Rostedt
On Fri, 31 May 2024 23:20:47 +0900 Masami Hiramatsu (Google) wrote: > The major conflict happens when the boot-time test cleans up the kprobe > events by > > dyn_events_release_all(&trace_kprobe_ops); > > And I removed it by [3/3] patch in this series :) because it does not > needed and not c

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-31 Thread Google
On Fri, 31 May 2024 03:24:25 -0400 Steven Rostedt wrote: > On Fri, 31 May 2024 11:37:21 +0900 > Masami Hiramatsu (Google) wrote: > > > So, in summary, it is designed to be a module. Steve, I think these tests > > should be kept as modules. There are many reason to do so. > > > > - This test i

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-31 Thread Steven Rostedt
On Fri, 31 May 2024 11:37:21 +0900 Masami Hiramatsu (Google) wrote: > So, in summary, it is designed to be a module. Steve, I think these tests > should be kept as modules. There are many reason to do so. > > - This test is designed to be used as module. > - This can conflict with other boot t

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-30 Thread Google
On Wed, 29 May 2024 11:01:43 -0500 Tom Zanussi wrote: > Hi Masami, > > On Wed, 2024-05-29 at 08:38 +0900, Masami Hiramatsu wrote: > > On Wed, 29 May 2024 01:46:40 +0900 > > Masami Hiramatsu (Google) wrote: > > > > > On Mon, 27 May 2024 19:29:07 -0400 > > > Steven Rostedt wrote: > > > > > > >

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-29 Thread Tom Zanussi
Hi Masami, On Wed, 2024-05-29 at 08:38 +0900, Masami Hiramatsu wrote: > On Wed, 29 May 2024 01:46:40 +0900 > Masami Hiramatsu (Google) wrote: > > > On Mon, 27 May 2024 19:29:07 -0400 > > Steven Rostedt wrote: > > > > > On Sun, 26 May 2024 19:10:57 +0900 > > > "Masami Hiramatsu (Google)" wrote

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-28 Thread Google
On Wed, 29 May 2024 01:46:40 +0900 Masami Hiramatsu (Google) wrote: > On Mon, 27 May 2024 19:29:07 -0400 > Steven Rostedt wrote: > > > On Sun, 26 May 2024 19:10:57 +0900 > > "Masami Hiramatsu (Google)" wrote: > > > > > Hi, > > > > > > Here is a series of some fixes/improvements for the test

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-28 Thread Google
On Mon, 27 May 2024 19:29:07 -0400 Steven Rostedt wrote: > On Sun, 26 May 2024 19:10:57 +0900 > "Masami Hiramatsu (Google)" wrote: > > > Hi, > > > > Here is a series of some fixes/improvements for the test modules and boot > > time selftest of kprobe events. I found a WARNING message with some

Re: [PATCH 0/3] tracing: Fix some selftest issues

2024-05-27 Thread Steven Rostedt
On Sun, 26 May 2024 19:10:57 +0900 "Masami Hiramatsu (Google)" wrote: > Hi, > > Here is a series of some fixes/improvements for the test modules and boot > time selftest of kprobe events. I found a WARNING message with some boot > time selftest configuration, which came from the combination of

[PATCH 0/3] tracing: Fix some selftest issues

2024-05-26 Thread Masami Hiramatsu (Google)
Hi, Here is a series of some fixes/improvements for the test modules and boot time selftest of kprobe events. I found a WARNING message with some boot time selftest configuration, which came from the combination of embedded kprobe generate API tests module and ftrace boot-time selftest. So the ma