Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Russell King - ARM Linux
On Thu, Dec 05, 2013 at 04:06:10PM -0800, Greg Kroah-Hartman wrote: > On Thu, Dec 05, 2013 at 06:54:49PM -0500, Adrien Vergé wrote: > > > Well, these patches were incorrect, so that's not really a valid > > > question :) > > > > Should I correct the pid size and send them again? > > I'm not the A

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 06:54:49PM -0500, Adrien Vergé wrote: > > Well, these patches were incorrect, so that's not really a valid > > question :) > > Should I correct the pid size and send them again? I'm not the ARM maintainer, so I can't say if I would reject them or not. And I don't know if

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Adrien Vergé
Hi Greg and Christopher, Thank you for your feedback. 2013/12/4 Greg Kroah-Hartman > What is it's purpose then? At first glance, this seems to be exactly > what 'perf' provides already. Doesn't perf work on ARM today? On ARM, perf is unable to trace every instruction, and certainly not record

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 05:45:12PM -0500, Christopher Covington wrote: > On 12/05/2013 03:16 PM, Greg Kroah-Hartman wrote: > > On Thu, Dec 05, 2013 at 03:12:50PM -0500, Christopher Covington wrote: > [...] > > And adding new features to code that is "dead" and should probably be > > removed isn't a

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Christopher Covington
On 12/05/2013 03:16 PM, Greg Kroah-Hartman wrote: > On Thu, Dec 05, 2013 at 03:12:50PM -0500, Christopher Covington wrote: [...] > And adding new features to code that is "dead" and should probably be > removed isn't a good idea, as I'm sure you can understand. I would consider feature additions t

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 03:12:50PM -0500, Christopher Covington wrote: > Hi Greg, > > On 12/04/2013 11:01 PM, Greg Kroah-Hartman wrote: > > On Wed, Dec 04, 2013 at 10:49:25PM -0500, Adrien Vergé wrote: > >> 2013/12/4 Greg Kroah-Hartman : > >>> How much overhead does the existing tracing code have

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-05 Thread Christopher Covington
Hi Greg, On 12/04/2013 11:01 PM, Greg Kroah-Hartman wrote: > On Wed, Dec 04, 2013 at 10:49:25PM -0500, Adrien Vergé wrote: >> 2013/12/4 Greg Kroah-Hartman : >>> How much overhead does the existing tracing code have on ARM? Is ETM >>> still even needed? Why not just use ETM for the core tracing c

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Greg Kroah-Hartman
On Wed, Dec 04, 2013 at 10:49:25PM -0500, Adrien Vergé wrote: > 2013/12/4 Greg Kroah-Hartman : > > How much overhead does the existing tracing code have on ARM? Is ETM > > still even needed? Why not just use ETM for the core tracing code > > instead? > > Coresight ETM is not just faster than /sy

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Adrien Vergé
2013/12/4 Greg Kroah-Hartman : > How much overhead does the existing tracing code have on ARM? Is ETM > still even needed? Why not just use ETM for the core tracing code > instead? Coresight ETM is not just faster than /sys/kernel/debug/tracing, it provides more detailed and customisable info. F

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Greg Kroah-Hartman
On Wed, Dec 04, 2013 at 04:12:56PM -0500, Adrien Vergé wrote: > 2013/12/4 Greg Kroah-Hartman : > > Your pid implementation is broken, see my other email about that :( > > Thank you for your remarks on pid. I'll try to correct that. > > > And again, what's wrong with the existing tracing functiona

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Adrien Vergé
2013/12/4 Greg Kroah-Hartman : > Your pid implementation is broken, see my other email about that :( Thank you for your remarks on pid. I'll try to correct that. > And again, what's wrong with the existing tracing functionalty that is > processor agnostic? Why can't we just delete this driver to

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Greg Kroah-Hartman
On Wed, Dec 04, 2013 at 11:52:34AM -0500, Adrien Vergé wrote: > Hi all, > > First, please excuse me for these misformatted patches that my email > client messed up. Next time I will use git send-email. The 3 patches > can be found on > http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-04 Thread Adrien Vergé
Hi all, First, please excuse me for these misformatted patches that my email client messed up. Next time I will use git send-email. The 3 patches can be found on http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=refs/heads/etm_with_addr_and_pid Greg: you're right, sysfs is a questiona

Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-03 Thread Greg Kroah-Hartman
On Tue, Dec 03, 2013 at 11:39:21PM -0500, Adrien Vergé wrote: > Usage of ETM tracing facility is currently very limited: user can > only start/stop tracing. This set of patches enables management of > address combinations and PIDs that trigger tracing. > > ETM management was done via sysfs entries

[PATCH 0/3] ARM Coresight: Enhance ETM tracing control

2013-12-03 Thread Adrien Vergé
Usage of ETM tracing facility is currently very limited: user can only start/stop tracing. This set of patches enables management of address combinations and PIDs that trigger tracing. ETM management was done via sysfs entries (trace_info, trace_running...), this code adds trace_addrrange and trac