Re: [PATCH 0/2] wait/ptrace: always assume __WALL if the child is traced

2015-10-25 Thread Oleg Nesterov
On 10/22, Pedro Alves wrote: > > In any case, to make sure existing gdb binaries would still work > with your kernel change, I ran GDB's testsuite with this: > > ~~ > diff --git a/gdb/nat/linux-waitpid.c b/gdb/nat/linux-waitpid.c > index cbcdd95..864ba2e 100644 > --- a/g

Re: [PATCH 0/2] wait/ptrace: always assume __WALL if the child is traced

2015-10-22 Thread Pedro Alves
On 10/20/2015 06:17 PM, Oleg Nesterov wrote: > Jan, Pedro, could you please confirm this won't break gdb? I tried > to look into gdb-7.1, and at first glance gdb uses __WCLONE only > because __WALL doesn't work on older kernels, iow it seems to me > that gdb actually wants __WALL so this change sh

Re: [PATCH 0/2] wait/ptrace: always assume __WALL if the child is traced

2015-10-20 Thread Oleg Nesterov
Forgot to say... Another question is why PTRACE_TRACEME succeeds in this case. I guess it is to late to change (break) the rules, but I never understood the security checks. The comment above cap_ptrace_traceme() says: Determine whether another process may trace the current and "another

[PATCH 0/2] wait/ptrace: always assume __WALL if the child is traced

2015-10-20 Thread Oleg Nesterov
Damn. I simply do not know what should/can we do. From the change log: And I can only hope that this won't break something. yet this patch cc's -stable. Please see the changelog, but in short: this is not a kernel bug but unlikely we can fix all distributions, so I think we have to chan