On Sun, 7 Mar 2021 12:01:42 +0800
Peter Chen wrote:
> On 21-03-02 09:56:05, Steven Rostedt wrote:
> > On Tue, 2 Mar 2021 16:23:55 +0800
> > Peter Chen wrote:
> >
> > s it looks like it uses %pa which IIUC from the printk code, it
> > > > >> dereferences the pointer to find it's virtual addres
On 21-03-02 09:56:05, Steven Rostedt wrote:
> On Tue, 2 Mar 2021 16:23:55 +0800
> Peter Chen wrote:
>
> s it looks like it uses %pa which IIUC from the printk code, it
> > > >> dereferences the pointer to find it's virtual address. The event has
> > > >> this as the field:
> > > >>
> > > >>
On Wed, 3 Mar 2021 09:21:39 +0800
Peter Chen wrote:
> On 21-03-02 09:56:05, Steven Rostedt wrote:
> > On Tue, 2 Mar 2021 16:23:55 +0800
> > Peter Chen wrote:
> >
> > s it looks like it uses %pa which IIUC from the printk code, it
> > > > >> dereferences the pointer to find it's virtual addres
On 21-03-02 09:56:05, Steven Rostedt wrote:
> On Tue, 2 Mar 2021 16:23:55 +0800
> Peter Chen wrote:
>
> s it looks like it uses %pa which IIUC from the printk code, it
> > > >> dereferences the pointer to find it's virtual address. The event has
> > > >> this as the field:
> > > >>
> > > >>
On Tue, 2 Mar 2021 16:23:55 +0800
Peter Chen wrote:
s it looks like it uses %pa which IIUC from the printk code, it
> > >> dereferences the pointer to find it's virtual address. The event has
> > >> this as the field:
> > >>
> > >> __field(struct cdns3_trb *, start_trb_addr)
> > >
On 21-03-01 05:27:04, Pawel Laszczak wrote:
>
> + Peter Chen - Maintainer of CDNS3 driver
>
> >
> >[ Resending with an address that should work for Felipe ]
> >
> >On Sat, 27 Feb 2021 14:18:02 -0500
> >Steven Rostedt wrote:
> >
> >> On Fri, 26 Feb 2021 14:21:00 -0800
> >> Linus Torvalds wrote:
+ Peter Chen - Maintainer of CDNS3 driver
>
>[ Resending with an address that should work for Felipe ]
>
>On Sat, 27 Feb 2021 14:18:02 -0500
>Steven Rostedt wrote:
>
>> On Fri, 26 Feb 2021 14:21:00 -0800
>> Linus Torvalds wrote:
>>
>> > On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt
>> > wr
[ Resending with an address that should work for Felipe ]
On Sat, 27 Feb 2021 14:18:02 -0500
Steven Rostedt wrote:
> On Fri, 26 Feb 2021 14:21:00 -0800
> Linus Torvalds wrote:
>
> > On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt
> > wrote:
> > >
> > > The first patch scans the print fmt
On Fri, 26 Feb 2021 14:21:00 -0800
Linus Torvalds wrote:
> On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt wrote:
> >
> > The first patch scans the print fmts of the trace events looking for
> > dereferencing pointers from %p*, and making sure that they refer back
> > to the trace event itself.
On Fri, 2021-02-26 at 18:33 -0500, Steven Rostedt wrote:
> On Fri, 26 Feb 2021 14:21:00 -0800
> Linus Torvalds wrote:
>
> > > The second patch handles strings "%s" [..]
> >
> > Doing this at runtime really feels like the wrong thing to do.
> >
> > It won't even protect us from what happened -
On Fri, 26 Feb 2021 14:21:00 -0800
Linus Torvalds wrote:
> > The second patch handles strings "%s" [..]
>
> Doing this at runtime really feels like the wrong thing to do.
>
> It won't even protect us from what happened - people like me and
> Andrew won't even run those tracepoints in the firs
On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt wrote:
>
> The first patch scans the print fmts of the trace events looking for
> dereferencing pointers from %p*, and making sure that they refer back
> to the trace event itself.
>
> The second patch handles strings "%s" [..]
Doing this at runtime
After seeing that an unsafe string dereference in a trace event made
it into the kernel, I decided it's time to add some sanity checks to
catch these cases without needing me to supervise.
The first patch scans the print fmts of the trace events looking for
dereferencing pointers from %p*, and m
13 matches
Mail list logo
