Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-29 Thread Seth Jennings
Forget this whole thing, these reverts do _not_ fix the issue. I wrote a test program to exercises cleancache and determined that this problem has existed since the as far back at v3.1 (basically the beginning). No recent commit caused this. Seth -- To unsubscribe from this list: send the line

Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-24 Thread Seth Jennings
On 08/23/2012 06:28 PM, Minchan Kim wrote: > Okay, then, why do you think the patchsets are culprit? > I didn't look the cleanup patch series of Xiao at that time > so I can be wrong but as I just look through patch of > "zcache: optimize zcache_do_preload", I can't find any fault > because zcache_

Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-23 Thread Xiao Guangrong
On 08/24/2012 07:28 AM, Minchan Kim wrote: > On Thu, Aug 23, 2012 at 05:10:00PM -0500, Seth Jennings wrote: >> On 08/23/2012 03:56 PM, Minchan Kim wrote: >>> Hi Seth, >>> >>> On Thu, Aug 23, 2012 at 10:33:09AM -0500, Seth Jennings wrote: This patchset fixes a regression in 3.6 by reverting two

Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-23 Thread Minchan Kim
On Thu, Aug 23, 2012 at 05:10:00PM -0500, Seth Jennings wrote: > On 08/23/2012 03:56 PM, Minchan Kim wrote: > > Hi Seth, > > > > On Thu, Aug 23, 2012 at 10:33:09AM -0500, Seth Jennings wrote: > >> This patchset fixes a regression in 3.6 by reverting two dependent > >> commits that made changes to

Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-23 Thread Seth Jennings
On 08/23/2012 03:56 PM, Minchan Kim wrote: > Hi Seth, > > On Thu, Aug 23, 2012 at 10:33:09AM -0500, Seth Jennings wrote: >> This patchset fixes a regression in 3.6 by reverting two dependent >> commits that made changes to zcache_do_preload(). >> >> The commits undermine an assumption made by tmem

Re: [PATCH 0/2] revert changes to zcache_do_preload()

2012-08-23 Thread Minchan Kim
Hi Seth, On Thu, Aug 23, 2012 at 10:33:09AM -0500, Seth Jennings wrote: > This patchset fixes a regression in 3.6 by reverting two dependent > commits that made changes to zcache_do_preload(). > > The commits undermine an assumption made by tmem_put() in > the cleancache path that preemption is d

[PATCH 0/2] revert changes to zcache_do_preload()

2012-08-23 Thread Seth Jennings
This patchset fixes a regression in 3.6 by reverting two dependent commits that made changes to zcache_do_preload(). The commits undermine an assumption made by tmem_put() in the cleancache path that preemption is disabled. This change introduces a race condition that can result in the wrong page