Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-18 Thread Martin K. Petersen
Christoph, > On Wed, Sep 18, 2019 at 11:08:07AM -0600, Keith Busch wrote: >> And yes, that bouncing is really nasty, but it's really only needed for >> PRP, so maybe let's just not ignore that transfer mode and support >> extended metadata iff the controller supports SGLs. We just need a >> spec

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-18 Thread Christoph Hellwig
On Wed, Sep 18, 2019 at 11:08:07AM -0600, Keith Busch wrote: > And yes, that bouncing is really nasty, but it's really only needed for > PRP, so maybe let's just not ignore that transfer mode and support > extended metadata iff the controller supports SGLs. We just need a > special SGL setup routin

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-18 Thread Keith Busch
On Wed, Sep 18, 2019 at 03:26:11PM +0200, Christoph Hellwig wrote: > Even if we had a use case for that the bounce buffer is just too ugly > to live. And I'm really sick and tired of Intel wasting our time for > their out of tree monster given that they haven't even tried helping > to improve the

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-18 Thread Christoph Hellwig
On Tue, Sep 17, 2019 at 10:39:09AM -0600, Keith Busch wrote: > On Mon, Sep 16, 2019 at 12:13:24PM +, Baldyga, Robert wrote: > > Ok, fair enough. We want to keep things hidden behind certain layers, > > and that's definitely a good thing. But there is a problem with these > > layers - they do no

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-17 Thread Keith Busch
On Mon, Sep 16, 2019 at 12:13:24PM +, Baldyga, Robert wrote: > Ok, fair enough. We want to keep things hidden behind certain layers, > and that's definitely a good thing. But there is a problem with these > layers - they do not expose all the features. For example AFAIK there > is no clear way

RE: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-16 Thread Baldyga, Robert
On Mon, Sep 16, 2019 at 09:34:55AM +0200, Christoph Hellwig wrote: > On Mon, Sep 16, 2019 at 07:16:52AM +, Baldyga, Robert wrote: > > On Fri, Sep 13, 2019 at 04:37:09PM +0200, Christoph Hellwig wrote: > > > On Fri, Sep 13, 2019 at 01:16:08PM +0200, Robert Baldyga wrote: > > > > Hello, > > > >

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-16 Thread Christoph Hellwig
On Mon, Sep 16, 2019 at 07:16:52AM +, Baldyga, Robert wrote: > On Fri, Sep 13, 2019 at 04:37:09PM +0200, Christoph Hellwig wrote: > > On Fri, Sep 13, 2019 at 01:16:08PM +0200, Robert Baldyga wrote: > > > Hello, > > > > > > This patchset adds two functions providing kernel to kernel API > > >

RE: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-16 Thread Baldyga, Robert
On Fri, Sep 13, 2019 at 04:37:09PM +0200, Christoph Hellwig wrote: > On Fri, Sep 13, 2019 at 01:16:08PM +0200, Robert Baldyga wrote: > > Hello, > > > > This patchset adds two functions providing kernel to kernel API > > for submiting NVMe admin commands. This is for use of NVMe-aware > > block de

Re: [PATCH 0/2] nvme: Add kernel API for admin command

2019-09-13 Thread Christoph Hellwig
On Fri, Sep 13, 2019 at 01:16:08PM +0200, Robert Baldyga wrote: > Hello, > > This patchset adds two functions providing kernel to kernel API > for submiting NVMe admin commands. This is for use of NVMe-aware > block device drivers stacking on top of NVMe drives. An example of > such driver is Open

[PATCH 0/2] nvme: Add kernel API for admin command

2019-09-13 Thread Robert Baldyga
Hello, This patchset adds two functions providing kernel to kernel API for submiting NVMe admin commands. This is for use of NVMe-aware block device drivers stacking on top of NVMe drives. An example of such driver is Open CAS Linux [1] which uses NVMe extended LBA formats and thus needs to issue