On Monday, January 2, 2017 at 5:31:15 PM UTC-8, Logan Gunthorpe wrote:
> Hi,
>
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
>
On 10/01/17 11:50 PM, Greg Kroah-Hartman wrote:
> You should be printing against the ntb struct device, as that's the
> "correct" structure here, and not the PCI device at all, as that's too
> far up the device chain from what the driver is supposed to be doing.
Yup, agreed and thanks. My v2 pat
On Tue, Jan 10, 2017 at 04:34:41PM -0700, Logan Gunthorpe wrote:
>
>
> On 10/01/17 04:06 PM, Joe Perches wrote:
> > It might also be better to add and use YA
> > logging macro like ndev_dbg
> >
> > #define ndev_dvg(ndev, fmt, ...)\
> > dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__)
Sorry, sorry. I resent the wrong set :(
Logan
On 10/01/17 05:32 PM, Logan Gunthorpe wrote:
> Hi,
>
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See
Hi,
I had copied some poor code style from the NTB drivers into an unrelated
driver. Upon review of my new code, I learned it was not a good idea
to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
suggested I fix the problem at the source.
Thus, please merge the following two p
On 10/01/17 04:06 PM, Joe Perches wrote:
> It might also be better to add and use YA
> logging macro like ndev_dbg
>
> #define ndev_dvg(ndev, fmt, ...) \
> dev_dbg(&(ndev)->ntb.pdev->dev, fmt, ##__VA_ARGS__)
>
> so that the new temporaries that are used just
> for debugging are not r
On Tue, 2017-01-10 at 16:59 -0500, Jon Mason wrote:
> On Tue, Jan 10, 2017 at 4:55 PM, Jon Mason wrote:
> > On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote:
> > > Hi,
> > >
> > > I had copied some poor code style from the NTB drivers into an unrelated
> > > driver. Upon review of
On Tue, Jan 10, 2017 at 4:55 PM, Jon Mason wrote:
> On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote:
>> Hi,
>>
>> I had copied some poor code style from the NTB drivers into an unrelated
>> driver. Upon review of my new code, I learned it was not a good idea
>> to sweep dirty thing
On Mon, Jan 02, 2017 at 06:30:34PM -0700, Logan Gunthorpe wrote:
> Hi,
>
> I had copied some poor code style from the NTB drivers into an unrelated
> driver. Upon review of my new code, I learned it was not a good idea
> to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
> sugge
Hi,
I had copied some poor code style from the NTB drivers into an unrelated
driver. Upon review of my new code, I learned it was not a good idea
to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
suggested I fix the problem at the source.
Thus, please merge the following two p
10 matches
Mail list logo
