Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-03 Thread Masahiro Yamada
On Wed, Dec 4, 2024 at 7:06 AM Mark Brown wrote: > > On Tue, Dec 03, 2024 at 07:20:05PM +, Mark Brown wrote: > > On Mon, Dec 02, 2024 at 11:33:58AM -0800, Linus Torvalds wrote: > > > > If we have these kinds of big scripted things, right after the merge > > > window tends to be the best time t

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-03 Thread Mark Brown
On Tue, Dec 03, 2024 at 07:20:05PM +, Mark Brown wrote: > On Mon, Dec 02, 2024 at 11:33:58AM -0800, Linus Torvalds wrote: > > If we have these kinds of big scripted things, right after the merge > > window tends to be the best time to do them. The conflict potential of > > leaving it hanging i

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-03 Thread Mark Brown
On Mon, Dec 02, 2024 at 11:33:58AM -0800, Linus Torvalds wrote: > On Mon, 2 Dec 2024 at 07:15, Peter Zijlstra wrote: > > > > Perhaps we can ask Linus to run this now, before -next fills up again ? > > Sure. I did an unasked-for scripted 'remove_new' removal right after > rc1 for the same reason.

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Greg KH
On Mon, Dec 02, 2024 at 04:15:33PM +0100, Peter Zijlstra wrote: > On Mon, Dec 02, 2024 at 03:59:47PM +0100, Peter Zijlstra wrote: > > Clean up the existing export namespace code along the same lines of > > 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to > > __section("foo")") a

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Peter Zijlstra
On Mon, Dec 02, 2024 at 03:59:47PM +0100, Peter Zijlstra wrote: > Clean up the existing export namespace code along the same lines of > 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to > __section("foo")") and for the same reason, it is not desired for the > namespace argument t

Re: [PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Linus Torvalds
On Mon, 2 Dec 2024 at 07:15, Peter Zijlstra wrote: > > Perhaps we can ask Linus to run this now, before -next fills up again ? Sure. I did an unasked-for scripted 'remove_new' removal right after rc1 for the same reason. If we have these kinds of big scripted things, right after the merge window

[PATCH -v2 1/7] module: Convert symbol namespace to string literal

2024-12-02 Thread Peter Zijlstra
Clean up the existing export namespace code along the same lines of 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") and for the same reason, it is not desired for the namespace argument to be a macro expansion itself. git grep -l -e MODULE_IMPORT_NS -e EXPOR