Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-15 Thread Guenter Roeck
On 11/15/2015 03:54 PM, Niklas Cassel wrote: I think that Guenter's patch should be merged asap. Right now the bug it fixes stops us from boot testing in qemu. I'll send out a build (failure) report after -rc1 is out. Maybe that will create enough visibility to get the patch accepted (or offic

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-15 Thread Niklas Cassel
I think that Guenter's patch should be merged asap. Right now the bug it fixes stops us from boot testing in qemu. For the broken mctrl irq handling part, when Uwe has converted mxs-auart to use the generic irq init, I can do the same for etraxfs + make sure that it gets tested properly on real ha

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-02 Thread Uwe Kleine-König
Helo Niklas, On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote: > On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: > >> The function call in the etraxfs-uart driver was not renamed, > >> possibly due to interference with commit 7b9c5162c182 ("serial: > >> etraxfs-uart: use mctrl_gpio he

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-02 Thread Niklas Cassel
On 11/02/2015 08:37 AM, Uwe Kleine-König wrote: >> The function call in the etraxfs-uart driver was not renamed, >> possibly due to interference with commit 7b9c5162c182 ("serial: >> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). > Yes. BTW, 7b9c5162c182 looks broken, too, bec

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-02 Thread Niklas Cassel
Acked-by: Niklas Cassel On 11/02/2015 03:32 AM, Guenter Roeck wrote: > Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), > crisv32 either do not build or crash as follows. > > Unable to handle kernel NULL pointer dereference > Linux 4.3.0-rc7-next-20151101 #1 Sun Nov 1 11:41

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-02 Thread Uwe Kleine-König
On Mon, Nov 02, 2015 at 06:29:36AM -0800, Guenter Roeck wrote: > On 11/01/2015 11:37 PM, Uwe Kleine-König wrote: > >Hello, > > > >On Sun, Nov 01, 2015 at 06:32:56PM -0800, Guenter Roeck wrote: > >>Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), > >>crisv32 either do not buil

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-02 Thread Guenter Roeck
On 11/01/2015 11:37 PM, Uwe Kleine-König wrote: Hello, On Sun, Nov 01, 2015 at 06:32:56PM -0800, Guenter Roeck wrote: Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), crisv32 either do not build or crash as follows. Unable to handle kernel NULL pointer dereference Linux

Re: [PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-01 Thread Uwe Kleine-König
Hello, On Sun, Nov 01, 2015 at 06:32:56PM -0800, Guenter Roeck wrote: > Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), > crisv32 either do not build or crash as follows. > > Unable to handle kernel NULL pointer dereference > Linux 4.3.0-rc7-next-20151101 #1 Sun Nov 1 11:4

[PATCH -next] serial: etraxfs-uart: Fix crash

2015-11-01 Thread Guenter Roeck
Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename init function"), crisv32 either do not build or crash as follows. Unable to handle kernel NULL pointer dereference Linux 4.3.0-rc7-next-20151101 #1 Sun Nov 1 11:41:28 PST 2015 ... Call Trace: [] show_stack+0x0/0x9e [] printk+0x0/0x2c [] show_r