Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-09 Thread David Miller
From: Joe Perches Date: Fri, 06 Dec 2013 14:39:46 -0800 > Use the newly added generic routine ether_addr_equal_unaligned > to test if possibly unaligned to u16 Ethernet addresses are equal. > > This slightly improves comparison time for systems with > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. > >

[PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread Joe Perches
Use the newly added generic routine ether_addr_equal_unaligned to test if possibly unaligned to u16 Ethernet addresses are equal. This slightly improves comparison time for systems with CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Signed-off-by: Joe Perches --- net/batman-adv/main.h | 2 +- 1 file c

Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread David Miller
From: Joe Perches Date: Fri, 06 Dec 2013 13:17:01 -0800 > On Fri, 2013-12-06 at 15:39 -0500, David Miller wrote: >> If so, make a function for that in linux/etherdevice.h and invoke it >> in such places. You can name it something like >> "ether_addr_equal_unaligned()" or similar. > > I'll resub

Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread Joe Perches
On Fri, 2013-12-06 at 15:39 -0500, David Miller wrote: > From: Joe Perches > Date: Fri, 06 Dec 2013 00:18:10 -0800 > > > @@ -266,7 +266,11 @@ static inline void batadv_dbg(int type __always_unused, > > */ > > static inline int batadv_compare_eth(const void *data1, const void *data2) > > { > >

Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread David Miller
From: Joe Perches Date: Fri, 06 Dec 2013 00:18:10 -0800 > @@ -266,7 +266,11 @@ static inline void batadv_dbg(int type __always_unused, > */ > static inline int batadv_compare_eth(const void *data1, const void *data2) > { > - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0); > +#if def

Re: [PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread Antonio Quartulli
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/12/13 09:18, Joe Perches wrote: > Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to check if this > function can be optimized by using the generic ether_addr_equal. > > Remove the unnecessary ?: after the unoptimized memcmp. > > Signed-off-by: Jo

[PATCH -next] batadv: Slight optimization of batadv_compare_eth

2013-12-06 Thread Joe Perches
Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to check if this function can be optimized by using the generic ether_addr_equal. Remove the unnecessary ?: after the unoptimized memcmp. Signed-off-by: Joe Perches --- net/batman-adv/main.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) d