Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n

2019-01-04 Thread Lorenzo Pieralisi
On Tue, Dec 25, 2018 at 10:44:38AM +0800, Hanjun Guo wrote: > Hi Qian, > > Good catch, minor comments below. > > On 2018/12/25 1:20, Qian Cai wrote: > > rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before > > '{' token > ^^ > drivers > > > { return NULL; } > > ^ > > d

Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n

2018-12-24 Thread Hanjun Guo
Hi Qian, Good catch, minor comments below. On 2018/12/25 1:20, Qian Cai wrote: > rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' > token ^^ drivers > { return NULL; } > ^ > drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but > never de

[PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n

2018-12-24 Thread Qian Cai
rivers/acpi/arm64/iort.c:880:1: error: expected identifier or '(' before '{' token { return NULL; } ^ drivers/acpi/arm64/iort.c:879:39: warning: 'iort_fwspec_iommu_ops' used but never defined static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev);