Re: [PATCH -mm v6 06/13] pagemap: use walk->vma instead of calling find_vma()

2014-08-06 Thread Naoya Horiguchi
Hi Peter, On Wed, Aug 06, 2014 at 01:30:40PM -0400, Peter Feiner wrote: > On Fri, Aug 01, 2014 at 03:20:42PM -0400, Naoya Horiguchi wrote: > > Page table walker has the information of the current vma in mm_walk, so > > we don't have to call find_vma() in each pagemap_hugetlb_range() call. > > You

Re: [PATCH -mm v6 06/13] pagemap: use walk->vma instead of calling find_vma()

2014-08-06 Thread Peter Feiner
On Fri, Aug 01, 2014 at 03:20:42PM -0400, Naoya Horiguchi wrote: > Page table walker has the information of the current vma in mm_walk, so > we don't have to call find_vma() in each pagemap_hugetlb_range() call. You could also get rid of a bunch of code in pagemap_pte_range: --- fs/proc/task_mmu

[PATCH -mm v6 06/13] pagemap: use walk->vma instead of calling find_vma()

2014-08-01 Thread Naoya Horiguchi
Page table walker has the information of the current vma in mm_walk, so we don't have to call find_vma() in each pagemap_hugetlb_range() call. NULL-vma check is omitted because we assume that we never run hugetlb_entry() callback on the address without vma. And even if it were broken, null pointer