Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-06 Thread Sedat Dilek
On Thu, Jun 6, 2019 at 9:28 AM Oleg Nesterov wrote: > > On 06/05, Oleg Nesterov wrote: > > > > +int set_user_sigmask(const sigset_t __user *umask, size_t sigsetsize) > > { > > - if (!usigmask) > > - return 0; > > + sigset_t *kmask; > > Typo, this obviously should be > >

Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-06 Thread Oleg Nesterov
On 06/05, Oleg Nesterov wrote: > > +int set_user_sigmask(const sigset_t __user *umask, size_t sigsetsize) > { > - if (!usigmask) > - return 0; > + sigset_t *kmask; Typo, this obviously should be sigset_t kmask; I'll send v2. Dear Kbuild Test Robot, thank you very m

Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-05 Thread kbuild test robot
Hi Oleg, I love your patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/signal-simplify-set_user_sigmask-restore_user_sigmask/20190606-062512 base: git://git.cmpxchg.org/linux-mmotm.git master config: s

Re: [PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-05 Thread kbuild test robot
Hi Oleg, I love your patch! Perhaps something to improve: [auto build test WARNING on mmotm/master] url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/signal-simplify-set_user_sigmask-restore_user_sigmask/20190606-062512 base: git://git.cmpxchg.org/linux-mmotm.git master config: m

[PATCH -mm 1/1] signal: simplify set_user_sigmask/restore_user_sigmask

2019-06-05 Thread Oleg Nesterov
task->saved_sigmask and ->restore_sigmask are only used in the ret-from- syscall paths. This means that set_user_sigmask() can save ->blocked in ->saved_sigmask and do set_restore_sigmask() to indicate that ->blocked was modified. This way the callers do not need 2 sigset_t's passed to set/restore