Re: [PATCH -mm 1/1] audit: cleanup audit_log_start/wait_for_auditd mess

2013-06-07 Thread Oleg Nesterov
On 06/06, Andrew Morton wrote: > > On Mon, 3 Jun 2013 22:46:20 +0200 Oleg Nesterov wrote: > > > audit_log_start() tries to obfusticate the code/logic and > > reimplements wait_event_timeout() in a very confusing way. > > > > Just change wait_for_auditd() to use wait_event_timeout() > > and return

Re: [PATCH -mm 1/1] audit: cleanup audit_log_start/wait_for_auditd mess

2013-06-06 Thread Andrew Morton
On Mon, 3 Jun 2013 22:46:20 +0200 Oleg Nesterov wrote: > audit_log_start() tries to obfusticate the code/logic and > reimplements wait_event_timeout() in a very confusing way. > > Just change wait_for_auditd() to use wait_event_timeout() > and return bool. > > Also remove the unnecessary "ab =

[PATCH -mm 1/1] audit: cleanup audit_log_start/wait_for_auditd mess

2013-06-03 Thread Oleg Nesterov
audit_log_start() tries to obfusticate the code/logic and reimplements wait_event_timeout() in a very confusing way. Just change wait_for_auditd() to use wait_event_timeout() and return bool. Also remove the unnecessary "ab = NULL" initialization. Signed-off-by: Oleg Nesterov --- kernel/audit.