Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-12-01 Thread Adrian Bunk
On Tue, Nov 28, 2006 at 03:39:29AM -0500, Jeff Garzik wrote: >... > In the future, please use "---" not "--" as the separator your .sig, so > that it is not copied into the kernel changelog by git-applymbox. >... "-- " is the standard separator most MUAs can interpret - "---" would therefore be

Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-28 Thread Jeff Garzik
Robert Hancock wrote: The attached patch against 2.6.19-rc6-mm1 fixes some problems in sata_nv with ATAPI devices on controllers running in ADMA mode. Some of the logic in the nv_adma_bmdma_* functions was inverted causing a bunch of warnings and caused those functions not to work properly. Als

RE: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-27 Thread Allen Martin
> > static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance) > > { > > struct ata_host *host = dev_instance; > > int i, handled = 0; > > + u32 notifier_clears[2]; > > > > spin_lock(&host->lock); > > > > for (i = 0; i < host->n_ports; i++) { > > struct at

Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-27 Thread Jeff Garzik
Andrew Morton wrote: On Sun, 26 Nov 2006 14:20:19 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance) { struct ata_host *host = dev_instance; int i, handled = 0; + u32 notifier_clears[2]; spin_lock(&host->

Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-27 Thread Jeff Garzik
Andrew Morton wrote: On Sun, 26 Nov 2006 14:20:19 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance) { struct ata_host *host = dev_instance; int i, handled = 0; + u32 notifier_clears[2]; spin_lock(&host->

Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-27 Thread Andrew Morton
On Sun, 26 Nov 2006 14:20:19 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: > static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance) > { > struct ata_host *host = dev_instance; > int i, handled = 0; > + u32 notifier_clears[2]; > > spin_lock(&host->lock); > >

[PATCH -mm] sata_nv: fix ATAPI in ADMA mode

2006-11-26 Thread Robert Hancock
The attached patch against 2.6.19-rc6-mm1 fixes some problems in sata_nv with ATAPI devices on controllers running in ADMA mode. Some of the logic in the nv_adma_bmdma_* functions was inverted causing a bunch of warnings and caused those functions not to work properly. Also, when an ATAPI devic