Re: [PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-10 Thread Huang, Ying
"Kirill A. Shutemov" writes: > On Tue, Apr 10, 2018 at 08:57:19AM +0800, Huang, Ying wrote: >> >> the swap offset reported doesn't >> >> reflect this. And in the loop to report information of each sub-page, >> >> the swap offset isn't increased accordingly as that for PFN. >> >> >> >> BTW: migr

Re: [PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-10 Thread Kirill A. Shutemov
On Tue, Apr 10, 2018 at 08:57:19AM +0800, Huang, Ying wrote: > >> the swap offset reported doesn't > >> reflect this. And in the loop to report information of each sub-page, > >> the swap offset isn't increased accordingly as that for PFN. > >> > >> BTW: migration swap entries have PFN informatio

Re: [PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-09 Thread Huang, Ying
Hi, Andrew, "Huang, Ying" writes: > From: Huang Ying > > The swap offset reported by /proc//pagemap may be not correct for > PMD migration entry. If addr passed into pagemap_range() isn't > aligned with PMD start address, the swap offset reported doesn't > reflect this. And in the loop to rep

Re: [PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-09 Thread Huang, Ying
Andrew Morton writes: > On Sun, 8 Apr 2018 11:37:37 +0800 "Huang, Ying" wrote: > >> From: Huang Ying >> >> The swap offset reported by /proc//pagemap may be not correct for >> PMD migration entry. If addr passed into pagemap_range() isn't > > pagemap_pmd_range(), yes? Yes. Sorry for typo.

Re: [PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-09 Thread Andrew Morton
On Sun, 8 Apr 2018 11:37:37 +0800 "Huang, Ying" wrote: > From: Huang Ying > > The swap offset reported by /proc//pagemap may be not correct for > PMD migration entry. If addr passed into pagemap_range() isn't pagemap_pmd_range(), yes? > aligned with PMD start address, How can this situatio

[PATCH -mm] mm, pagemap: Fix swap offset value for PMD migration entry

2018-04-07 Thread Huang, Ying
From: Huang Ying The swap offset reported by /proc//pagemap may be not correct for PMD migration entry. If addr passed into pagemap_range() isn't aligned with PMD start address, the swap offset reported doesn't reflect this. And in the loop to report information of each sub-page, the swap offse