Re: [PATCH -mm] char: drivers use/need PCI

2006-11-29 Thread Randy Dunlap
Alan wrote: But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct temporary way and I'll add "|| ISA" after the proposed code fix :). That stops it being built on some platforms that have ISA and not PCI. Seems a poor fix for what really is a couple of ifdefs They c

Re: [PATCH -mm] char: drivers use/need PCI

2006-11-29 Thread Alan
> But those drivers support ISA devices too. Ok then, let "&& PCI" be as a > correct > temporary way and I'll add "|| ISA" after the proposed code fix :). That stops it being built on some platforms that have ISA and not PCI. Seems a poor fix for what really is a couple of ifdefs - To unsubscribe

Re: [PATCH -mm] char: drivers use/need PCI

2006-11-29 Thread Jiri Slaby
Randy Dunlap wrote: > Jiri Slaby wrote: >> Randy Dunlap wrote: >>> From: Randy Dunlap <[EMAIL PROTECTED]> >>> >>> With CONFIG_PCI=n: >>> drivers/char/mxser_new.c: In function 'mxser_release_res': >>> drivers/char/mxser_new.c:2383: warning: implicit declaration of >>> function 'pci_release_region' >

Re: [PATCH -mm] char: drivers use/need PCI

2006-11-29 Thread Randy Dunlap
Jiri Slaby wrote: Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> With CONFIG_PCI=n: drivers/char/mxser_new.c: In function 'mxser_release_res': drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' drivers/char/mxser_new.c: In function 'mxser_

Re: [PATCH -mm] char: drivers use/need PCI

2006-11-29 Thread Jiri Slaby
Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > With CONFIG_PCI=n: > drivers/char/mxser_new.c: In function 'mxser_release_res': > drivers/char/mxser_new.c:2383: warning: implicit declaration of function > 'pci_release_region' > drivers/char/mxser_new.c: In function 'mxser_probe':

[PATCH -mm] char: drivers use/need PCI

2006-11-28 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> With CONFIG_PCI=n: drivers/char/mxser_new.c: In function 'mxser_release_res': drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' drivers/char/mxser_new.c: In function 'mxser_probe': drivers/char/mxser_new.c:2578: wa