Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Linus Torvalds
On Sun, Apr 28, 2019 at 5:28 PM Waiman Long wrote: > > Not really, this is a serious problem that have to be backported to > earlier stable releases and downstream. The clever code is helpful in > those cases. Fair enough, I guess the code will live in the stable trees for a longish while.

Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Waiman Long
On 4/28/19 8:10 PM, Linus Torvalds wrote: > On Sun, Apr 28, 2019 at 4:12 PM Waiman Long wrote: >> I implemented your suggestion in patch 1 as it will produce simpler and >> faster code. However, one of the changes in my patchset is to wake up >> all the readers in the wait list. This means I have

Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Linus Torvalds
On Sun, Apr 28, 2019 at 4:12 PM Waiman Long wrote: > > I implemented your suggestion in patch 1 as it will produce simpler and > faster code. However, one of the changes in my patchset is to wake up > all the readers in the wait list. This means I have to jump over the > writers and wake up the re

Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Waiman Long
On 4/28/19 7:12 PM, Waiman Long wrote: > On 4/28/19 6:46 PM, Linus Torvalds wrote: >> This doesn't seem to be the full diff - looking at that patch 1 you >> seem to have taken my suggested list_cut_before() change too. >> >> I'm not against it (it does seem to be simpler and better), I just >> hope

Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Waiman Long
On 4/28/19 6:46 PM, Linus Torvalds wrote: > This doesn't seem to be the full diff - looking at that patch 1 you > seem to have taken my suggested list_cut_before() change too. > > I'm not against it (it does seem to be simpler and better), I just > hope you double-checked it, since I kind of hand-w

Re: [PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Linus Torvalds
This doesn't seem to be the full diff - looking at that patch 1 you seem to have taken my suggested list_cut_before() change too. I'm not against it (it does seem to be simpler and better), I just hope you double-checked it, since I kind of hand-waved it. Linus On Sun, Apr 28

[PATCH-tip v7 00/20] locking/rwsem: Rwsem rearchitecture part 2

2019-04-28 Thread Waiman Long
v7: - Fix a bug in patch 1 and include changes suggested by Linus. - Refresh the other patches accordingly. v6: - Add a new patch 1 to fix an existing rwsem bug that allows both readers and writer to become rwsem owners simultaneously. - Fix a missed wakeup bug (in patch 9) of the v5