On Tue, Aug 21, 2018 at 5:45 PM Sergey Senozhatsky
wrote:
>
> Hi,
>
> Did you intend to remove lkml mailing list from Cc?
>
No, that was an accident. I resent it so it's on the record.
I will submit a v2 patch with an updated commit message then.
On Tue, Aug 14, 2018 at 04:45:23PM -0700, Andrew Morton wrote:
> The changelog doesn't describe the end-user impact of the bug, which is
> very desirable when tagging a patch for -stable backporting. Can we
> have that paragraph please?
The end-user impact is that echoing to writeback_dev would n
On Thu, 16 Aug 2018 10:48:35 +0900 Sergey Senozhatsky
wrote:
> > The implementation might be able to use strim() somehow.
>
> strim() trims white-spaces.
Which includes \n.
> What we have here is a trailing new line symbol,
> which echo appends to the string it writes to the kernel [echo -n s
A bunch of corrections
On (08/16/18 10:48), Sergey Senozhatsky wrote:
> The problem is that strlcpy() copies as many bytes as the source string
> has, not as many bytes as destination string can fit.
I mean - strlcpy() expects that the 3rd argument will be sizeof(dst), but
we passed the wrong arg
On (08/14/18 16:45), Andrew Morton wrote:
> >
> > > > - strlcpy(file_name, buf, len);
> >
> > This is quite interesting. The reason it worked before was the fact that
> > strlcpy() copies 'len - 1' bytes, which is strlen(buf) - 1 in our case,
> > so it accidentally didn't copy the trailing
On Mon, 13 Aug 2018 16:38:25 +0900 Sergey Senozhatsky
wrote:
> On (08/13/18 15:16), Minchan Kim wrote:
> > > The call to strlcpy in backing_dev_store is incorrect. It should take
> > > the size of the destination buffer instead of the size of the source
> > > buffer. Additionally, ignore the ne
On (08/13/18 15:16), Minchan Kim wrote:
> > The call to strlcpy in backing_dev_store is incorrect. It should take
> > the size of the destination buffer instead of the size of the source
> > buffer. Additionally, ignore the newline character (\n) when reading
> > the new file_name buffer. This mak
On Wed, Aug 08, 2018 at 03:31:00PM -0700, Peter Kalauskas wrote:
> The call to strlcpy in backing_dev_store is incorrect. It should take
> the size of the destination buffer instead of the size of the source
> buffer. Additionally, ignore the newline character (\n) when reading
> the new file_name
8 matches
Mail list logo
