Re: [PATCH] zram: factor out partial IO routine

2017-03-30 Thread Sergey Senozhatsky
Hello, On (03/31/17 08:33), Minchan Kim wrote: [..] > > a bigger side effect is that now we double the amount of lines we need > > to change in certain patches and, thus, the amount of work - when we > > add new functionality/fix something in zram_bvec_{write, read} we also > > would need to touch

Re: [PATCH] zram: factor out partial IO routine

2017-03-30 Thread Minchan Kim
Hi Sergey, On Thu, Mar 30, 2017 at 01:12:38PM +0900, Sergey Senozhatsky wrote: > On (03/29/17 16:48), Minchan Kim wrote: > > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > > However, the mixed code for handling normal/partial IO is too mess, > > error-prone to modify IO handle

Re: [PATCH] zram: factor out partial IO routine

2017-03-29 Thread Sergey Senozhatsky
On (03/29/17 16:48), Minchan Kim wrote: > For architecture(PAGE_SIZE > 4K), zram have supported partial IO. > However, the mixed code for handling normal/partial IO is too mess, > error-prone to modify IO handler functions with upcoming feature > so this patch aims for cleaning up via factoring out

[PATCH] zram: factor out partial IO routine

2017-03-29 Thread Minchan Kim
For architecture(PAGE_SIZE > 4K), zram have supported partial IO. However, the mixed code for handling normal/partial IO is too mess, error-prone to modify IO handler functions with upcoming feature so this patch aims for cleaning up via factoring out partial IO routines to zram_bvec_partial_[read|