Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Joonsoo Kim
On Wed, Apr 23, 2014 at 11:52:08AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 11:08 AM, Joonsoo Kim wrote: > > On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > >> On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > >> wrote: > >> > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yan

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Weijie Yang
On Wed, Apr 23, 2014 at 11:08 AM, Joonsoo Kim wrote: > On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: >> On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton >> wrote: >> > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang >> > wrote: >> > >> >> we want to skip the logical block which is p

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Joonsoo Kim
On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > wrote: > > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang > > wrote: > > > >> we want to skip the logical block which is partially covered by > >> the discard bio, so check the remaini

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Weijie Yang
On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton wrote: > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang > wrote: > >> we want to skip the logical block which is partially covered by >> the discard bio, so check the remaining size and subtract it if >> there is a need to goto the next logical bloc

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Andrew Morton
On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang wrote: > we want to skip the logical block which is partially covered by > the discard bio, so check the remaining size and subtract it if > there is a need to goto the next logical block. > > This patch corrects the offset usage in zram_bio_discard

Re: [PATCH] zram: correct offset usage in zram_bio_discard

2014-04-22 Thread Sergey Senozhatsky
On (04/22/14 11:14), Weijie Yang wrote: > > we want to skip the logical block which is partially covered by > the discard bio, so check the remaining size and subtract it if > there is a need to goto the next logical block. > looks sane. -ss > This patch corrects the offset usage in zr

[PATCH] zram: correct offset usage in zram_bio_discard

2014-04-21 Thread Weijie Yang
we want to skip the logical block which is partially covered by the discard bio, so check the remaining size and subtract it if there is a need to goto the next logical block. This patch corrects the offset usage in zram_bio_discard. Signed-off-by: Weijie Yang --- drivers/block/zram/zram_drv.c