Re: [PATCH] xt_request_find_match

2006-12-20 Thread Patrick McHardy
Jan Engelhardt wrote: >>Make sure the user specifies the match on the command line before >>your match. Look at the TCPMSS or REJECT targets for examples for >>this. > > > That would mean I'd have to > > -p tcp -m multiport --dport 1,2,3,4 -m time --time sundays -m > lotsofothers -j TARGET >

Re: [PATCH] xt_request_find_match

2006-12-20 Thread Jan Engelhardt
>Jan Engelhardt wrote: >> [...] >> >> Ok, but let's say I wanted to use a bigger match module (layer7, anyone?) >> Then it's just not if(protocol == IPPROTO_TCP). What's the preferred solution >> then? > >Make sure the user specifies the match on the command line before >your match. Look at the TC

Re: [PATCH] xt_request_find_match

2006-12-20 Thread Patrick McHardy
Jan Engelhardt wrote: > [...] > > Ok, but let's say I wanted to use a bigger match module (layer7, anyone?) > Then it's just not if(protocol == IPPROTO_TCP). What's the preferred solution > then? Make sure the user specifies the match on the command line before your match. Look at the TCPMSS or RE

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Jan Engelhardt
Reusing code is a good idea, and I would like to do so from my match modules. netfilter already provides a xt_request_find_target() but an xt_request_find_match() does not yet exist. This patch adds it. >>> >>>Why does your match module needs to lookup other matches? >> >> To use th

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Patrick McHardy
Jan Engelhardt wrote: > On Dec 19 2006 12:51, Patrick McHardy wrote: > >>>Reusing code is a good idea, and I would like to do so from my >>>match modules. netfilter already provides a xt_request_find_target() but >>>an xt_request_find_match() does not yet exist. This patch adds it. >> >>Why does

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Jan Engelhardt
On Dec 19 2006 12:51, Patrick McHardy wrote: >> Reusing code is a good idea, and I would like to do so from my >> match modules. netfilter already provides a xt_request_find_target() but >> an xt_request_find_match() does not yet exist. This patch adds it. > >Why does your match module needs to

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Patrick McHardy
Jan Engelhardt wrote: > Reusing code is a good idea, and I would like to do so from my > match modules. netfilter already provides a xt_request_find_target() but > an xt_request_find_match() does not yet exist. This patch adds it. Why does your match module needs to lookup other matches? - To u

[PATCH] xt_request_find_match

2006-12-16 Thread Jan Engelhardt
Hi, Reusing code is a good idea, and I would like to do so from my match modules. netfilter already provides a xt_request_find_target() but an xt_request_find_match() does not yet exist. This patch adds it. Objections welcome :) --- Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: