On Fri, Nov 30, 2007 at 04:36:25PM -0600, Stephen Lord wrote:
> Wow, was it really that long ago!
>
> Looks like the readdir is in the bowels of the btree code when filldir gets
> called
> here, there are probably locks on several buffers in the btree at this
> point. This
> will only show up for
On Fri, Nov 30, 2007 at 06:22:09PM +1100, Timothy Shimmin wrote:
> Hmmm, don't see the point of "eof" local var now.
> Previously bhv_vop_readdir() returned eof.
> I presume if we don't move the offset (offset == startoffset) then
> we're done and break out?
> So we lost eof when going to the filld
On Nov 30, 2007, at 5:04 PM, Chris Wedgwood wrote:
On Fri, Nov 30, 2007 at 04:36:25PM -0600, Stephen Lord wrote:
Looks like the readdir is in the bowels of the btree code when
filldir gets called here, there are probably locks on several
buffers in the btree at this point. This will only show
On Fri, Nov 30, 2007 at 04:36:25PM -0600, Stephen Lord wrote:
> Looks like the readdir is in the bowels of the btree code when
> filldir gets called here, there are probably locks on several
> buffers in the btree at this point. This will only show up for large
> directories I bet.
I see it for f
Wow, was it really that long ago!
Looks like the readdir is in the bowels of the btree code when
filldir gets called
here, there are probably locks on several buffers in the btree at
this point. This
will only show up for large directories I bet.
The xfs readdir code has the complete xfs
On Fri, Nov 30, 2007 at 12:45:05AM +0100, Christian Kujau wrote:
> On Sun, 25 Nov 2007, Christoph Hellwig wrote:
> >This patch does exactly that and reverts xfs_file_readdir to what's
> >basically the 2.6.23 version minus the uio and vnops junk.
>
> Thanks, works here too (without nordirplus as a
Christoph Hellwig wrote:
The current readdir implementation deadlocks on a btree buffers locks
because nfsd calls back into ->lookup from the filldir callback. The
only short-term fix for this is to revert to the old inefficient
double-buffering scheme.
Probably why Steve did this: :)
xfs_fi
On Sun, 25 Nov 2007, Christoph Hellwig wrote:
This patch does exactly that and reverts xfs_file_readdir to what's
basically the 2.6.23 version minus the uio and vnops junk.
Thanks, works here too (without nordirplus as a mountoption).
Am I supposed to close the bug[0] or do you guys want to lea
On Sun, Nov 25, 2007 at 04:30:14PM +, Christoph Hellwig wrote:
> The current readdir implementation deadlocks on a btree buffers
> locks because nfsd calls back into ->lookup from the filldir
> callback. The only short-term fix for this is to revert to the old
> inefficient double-buffering s
The current readdir implementation deadlocks on a btree buffers locks
because nfsd calls back into ->lookup from the filldir callback. The
only short-term fix for this is to revert to the old inefficient
double-buffering scheme.
This patch does exactly that and reverts xfs_file_readdir to what's
10 matches
Mail list logo
