Re: [Xen-devel] [PATCH] xen-blkfront: switch from llist to list

2013-02-25 Thread konrad wilk
On 2/25/2013 12:00 PM, Roger Pau Monné wrote: On 25/02/13 17:49, Konrad Rzeszutek Wilk wrote: On Fri, Feb 15, 2013 at 08:12:52PM +0100, Roger Pau Monné wrote: On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote: Should be backported to 3.8 stable. Lets do one thing at a time. The patch I have in

Re: [Xen-devel] [PATCH] xen-blkfront: switch from llist to list

2013-02-25 Thread Roger Pau Monné
On 25/02/13 17:49, Konrad Rzeszutek Wilk wrote: > On Fri, Feb 15, 2013 at 08:12:52PM +0100, Roger Pau Monné wrote: >> On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote: Should be backported to 3.8 stable. >>> >>> Lets do one thing at a time. >>> >>> The patch I have in the tree (and that I've ask

Re: [Xen-devel] [PATCH] xen-blkfront: switch from llist to list

2013-02-25 Thread Konrad Rzeszutek Wilk
On Fri, Feb 15, 2013 at 08:12:52PM +0100, Roger Pau Monné wrote: > On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote: > >> Should be backported to 3.8 stable. > > > > Lets do one thing at a time. > > > > The patch I have in the tree (and that I've asked Jens to pull for 3.9 - so > > he might have al

Re: [PATCH] xen-blkfront: switch from llist to list

2013-02-15 Thread Roger Pau Monné
On 15/02/13 19:56, Konrad Rzeszutek Wilk wrote: >> Should be backported to 3.8 stable. > > Lets do one thing at a time. > > The patch I have in the tree (and that I've asked Jens to pull for 3.9 - so > he might have already in his tree) is the old hybrid where we still use llist > but change the

Re: [PATCH] xen-blkfront: switch from llist to list

2013-02-15 Thread Konrad Rzeszutek Wilk
> Should be backported to 3.8 stable. Lets do one thing at a time. The patch I have in the tree (and that I've asked Jens to pull for 3.9 - so he might have already in his tree) is the old hybrid where we still use llist but change the loop from 'for' to 'while'. This is the stable/for-jens-3.8

[PATCH] xen-blkfront: switch from llist to list

2013-02-15 Thread Roger Pau Monne
Replace the use of llist with list. llist_for_each_entry_safe can trigger a bug in GCC 4.1, so it's best to remove it and use a doubly linked list, which is used extensively in the kernel already. Specifically this bug can be triggered by hot-unplugging a disk, either by doing xm block-detach or