Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Greg KH
On Wed, May 03, 2017 at 04:12:29PM -0700, Stefano Stabellini wrote: > On Wed, 3 May 2017, Greg KH wrote: > > On Wed, May 03, 2017 at 03:59:15PM -0700, Stefano Stabellini wrote: > > > On Wed, 3 May 2017, Boris Ostrovsky wrote: > > > > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > > > > On Wed,

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Greg KH wrote: > On Wed, May 03, 2017 at 03:59:15PM -0700, Stefano Stabellini wrote: > > On Wed, 3 May 2017, Boris Ostrovsky wrote: > > > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > > > >> On 02/22/2017 09:28

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Greg KH
On Wed, May 03, 2017 at 03:59:15PM -0700, Stefano Stabellini wrote: > On Wed, 3 May 2017, Boris Ostrovsky wrote: > > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > > >> On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > > >>> On Tue, Feb

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Boris Ostrovsky wrote: > On 05/03/2017 02:19 PM, David Woodhouse wrote: > > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > >> On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > >>> On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: > On 02/21/2017 10:

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread Boris Ostrovsky
On 05/03/2017 02:19 PM, David Woodhouse wrote: > On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: >> On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: >>> On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: On 02/21/2017 10:45 AM, Juergen Gross wrote: > On 21/02/17 16:31,

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-05-03 Thread David Woodhouse
On Wed, 2017-02-22 at 10:14 -0500, Boris Ostrovsky wrote: > On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > > > > On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: > > > > > > On 02/21/2017 10:45 AM, Juergen Gross wrote: > > > > > > > > On 21/02/17 16:31, Dan Streetman wrote: > > >

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-22 Thread Boris Ostrovsky
On 02/22/2017 09:28 AM, Bjorn Helgaas wrote: > On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: >> On 02/21/2017 10:45 AM, Juergen Gross wrote: >>> On 21/02/17 16:31, Dan Streetman wrote: On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 13,

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-22 Thread Bjorn Helgaas
On Tue, Feb 21, 2017 at 10:58:39AM -0500, Boris Ostrovsky wrote: > On 02/21/2017 10:45 AM, Juergen Gross wrote: > > On 21/02/17 16:31, Dan Streetman wrote: > >> On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk > >> wrote: > >>> On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: >

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-21 Thread Boris Ostrovsky
On 02/21/2017 10:45 AM, Juergen Gross wrote: > On 21/02/17 16:31, Dan Streetman wrote: >> On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk >> wrote: >>> On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: Revert the main part of commit: af42b8d12f8a ("xen: fix MSI setup

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-21 Thread Juergen Gross
On 21/02/17 16:31, Dan Streetman wrote: > On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk > wrote: >> On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: >>> Revert the main part of commit: >>> af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") >>> >>> That com

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-02-21 Thread Dan Streetman
On Fri, Jan 13, 2017 at 5:30 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: >> Revert the main part of commit: >> af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") >> >> That commit introduced reading the pci device's msi messa

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Konrad Rzeszutek Wilk
On Fri, Jan 13, 2017 at 03:07:51PM -0500, Dan Streetman wrote: > Revert the main part of commit: > af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") > > That commit introduced reading the pci device's msi message data to see > if a pirq was previously configured for the device'

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Boris Ostrovsky
On 01/13/2017 03:07 PM, Dan Streetman wrote: > Revert the main part of commit: > af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") > > That commit introduced reading the pci device's msi message data to see > if a pirq was previously configured for the device's msi/msix, and re-

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Stefano Stabellini
On Fri, 13 Jan 2017, Dan Streetman wrote: > Revert the main part of commit: > af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") > > That commit introduced reading the pci device's msi message data to see > if a pirq was previously configured for the device's msi/msix, and re-us

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
On Fri, Jan 13, 2017 at 3:00 PM, Boris Ostrovsky wrote: > On 01/13/2017 01:44 PM, Stefano Stabellini wrote: >> On Fri, 13 Jan 2017, Dan Streetman wrote: >>> On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini wrote: > On Wed, 11

[PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
Revert the main part of commit: af42b8d12f8a ("xen: fix MSI setup and teardown for PV on HVM guests") That commit introduced reading the pci device's msi message data to see if a pirq was previously configured for the device's msi/msix, and re-use that pirq. At the time, that was the correct beha

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Boris Ostrovsky
On 01/13/2017 01:44 PM, Stefano Stabellini wrote: > On Fri, 13 Jan 2017, Dan Streetman wrote: >> On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: >>> On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini >>> wrote: On Wed, 11 Jan 2017, Dan Streetman wrote: > On Tue, Jan 10, 2017 at 8:

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Dan Streetman
On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: > On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini > wrote: >> On Wed, 11 Jan 2017, Dan Streetman wrote: >>> On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini >>> wrote: >>> > On Tue, 10 Jan 2017, Dan Streetman wrote: >>> >> On Tue, Jan

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-13 Thread Stefano Stabellini
On Fri, 13 Jan 2017, Dan Streetman wrote: > On Wed, Jan 11, 2017 at 6:25 PM, Dan Streetman wrote: > > On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini > > wrote: > >> On Wed, 11 Jan 2017, Dan Streetman wrote: > >>> On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini > >>> wrote: > >>> > On Tu

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-11 Thread Dan Streetman
On Wed, Jan 11, 2017 at 1:46 PM, Stefano Stabellini wrote: > On Wed, 11 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini >> wrote: >> > On Tue, 10 Jan 2017, Dan Streetman wrote: >> >> On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini >> >> wrote: >> >> > On

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-11 Thread Stefano Stabellini
On Wed, 11 Jan 2017, Dan Streetman wrote: > On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini > wrote: > > On Tue, 10 Jan 2017, Dan Streetman wrote: > >> On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini > >> wrote: > >> > On Tue, 10 Jan 2017, Dan Streetman wrote: > >> >> On Tue, Jan 10, 2017

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-11 Thread Dan Streetman
On Tue, Jan 10, 2017 at 8:25 PM, Stefano Stabellini wrote: > On Tue, 10 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini >> wrote: >> > On Tue, 10 Jan 2017, Dan Streetman wrote: >> >> On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: >> >> > On Mon, Jan

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Stefano Stabellini
On Tue, 10 Jan 2017, Dan Streetman wrote: > On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini > wrote: > > On Tue, 10 Jan 2017, Dan Streetman wrote: > >> On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: > >> > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini > >> > wrote: > >> >> On Mo

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Boris Ostrovsky
>> In the Xen code I can still see: >> >> case ECS_PIRQ: { >> struct pirq *pirq = pirq_info(d1, chn1->u.pirq.irq); >> >> if ( !pirq ) >> break; >> if ( !is_hvm_domain(d1) ) >> pirq_guest_unbind(d1, pirq); >> >> which means that pirq_guest_unbind

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Tue, Jan 10, 2017 at 2:03 PM, Stefano Stabellini wrote: > On Tue, 10 Jan 2017, Dan Streetman wrote: >> On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: >> > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini >> > wrote: >> >> On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: >> >>> On Mo

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Stefano Stabellini
On Tue, 10 Jan 2017, Dan Streetman wrote: > On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: > > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini > > wrote: > >> On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: > >>> On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: > >>> > O

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Tue, Jan 10, 2017 at 10:57 AM, Dan Streetman wrote: > On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini > wrote: >> On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: >>> On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: >>> > On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky >>> >

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-10 Thread Dan Streetman
On Mon, Jan 9, 2017 at 2:30 PM, Stefano Stabellini wrote: > On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: >> On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: >> > On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky >> > wrote: >> > > On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrot

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-09 Thread Stefano Stabellini
On Mon, 9 Jan 2017, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: > > On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky > > wrote: > > > On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrote: > > >> On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-09 Thread Konrad Rzeszutek Wilk
On Mon, Jan 09, 2017 at 10:42:41AM -0500, Dan Streetman wrote: > On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky > wrote: > > On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrote: > >> On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman wrote: > >>> Do not read a pci device's msi message data t

Re: [Xen-devel] [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-09 Thread Dan Streetman
On Mon, Jan 9, 2017 at 9:59 AM, Boris Ostrovsky wrote: > On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrote: >> On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman wrote: >>> Do not read a pci device's msi message data to see if a pirq was >>> previously configured for the device's msi/msix,

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-09 Thread Boris Ostrovsky
On 01/06/2017 08:06 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman wrote: >> Do not read a pci device's msi message data to see if a pirq was >> previously configured for the device's msi/msix, as the old pirq was >> unmapped and may now be in use by anot

Re: [PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-06 Thread Konrad Rzeszutek Wilk
On Thu, Jan 05, 2017 at 02:28:56PM -0500, Dan Streetman wrote: > Do not read a pci device's msi message data to see if a pirq was > previously configured for the device's msi/msix, as the old pirq was > unmapped and may now be in use by another pci device. The previous > pirq should never be re-us

[PATCH] xen: do not re-use pirq number cached in pci device msi msg data

2017-01-05 Thread Dan Streetman
Do not read a pci device's msi message data to see if a pirq was previously configured for the device's msi/msix, as the old pirq was unmapped and may now be in use by another pci device. The previous pirq should never be re-used; instead a new pirq should always be allocated from the hypervisor.