Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 11/01/2019 08:15, Juergen Gross wrote: > On 11/01/2019 00:10, Boris Ostrovsky wrote: >> On 1/10/19 12:17 PM, Boris Ostrovsky wrote: >>> On 1/10/19 11:14 AM, Juergen Gross wrote: On 10/01/2019 16:34, Boris Ostrovsky wrote: > On 1/10/19 5:07 AM, Juergen Gross wrote: >> >> +void

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 11/01/2019 00:10, Boris Ostrovsky wrote: > On 1/10/19 12:17 PM, Boris Ostrovsky wrote: >> On 1/10/19 11:14 AM, Juergen Gross wrote: >>> On 10/01/2019 16:34, Boris Ostrovsky wrote: On 1/10/19 5:07 AM, Juergen Gross wrote: > > +void xen_clocksource_suspend(void) > +{ > + xen

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Boris Ostrovsky
On 1/10/19 12:17 PM, Boris Ostrovsky wrote: > On 1/10/19 11:14 AM, Juergen Gross wrote: >> On 10/01/2019 16:34, Boris Ostrovsky wrote: >>> On 1/10/19 5:07 AM, Juergen Gross wrote: +void xen_clocksource_suspend(void) +{ + xen_clock_value_saved = xen_clocksource_read() - xen_sc

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Boris Ostrovsky
On 1/10/19 11:14 AM, Juergen Gross wrote: > On 10/01/2019 16:34, Boris Ostrovsky wrote: >> On 1/10/19 5:07 AM, Juergen Gross wrote: >>> >>> +void xen_clocksource_suspend(void) >>> +{ >>> + xen_clock_value_saved = xen_clocksource_read() - xen_sched_clock_offset; >> >> xen_clock_value_saved = xen

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Hans van Kranenburg
On 1/10/19 11:07 AM, Juergen Gross wrote: > Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' > sched_clock() interface") broke Xen guest time handling across > migration: > > [ 187.249951] Freezing user space processes ... (elapsed 0.001 seconds) done. > [ 187.251137] OOM

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
On 10/01/2019 16:34, Boris Ostrovsky wrote: > On 1/10/19 5:07 AM, Juergen Gross wrote: >> >> +void xen_clocksource_suspend(void) >> +{ >> +xen_clock_value_saved = xen_clocksource_read() - xen_sched_clock_offset; > > > xen_clock_value_saved = xen_sched_clock() maybe? I wanted xen_clocksour

Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Boris Ostrovsky
On 1/10/19 5:07 AM, Juergen Gross wrote: > > +void xen_clocksource_suspend(void) > +{ > + xen_clock_value_saved = xen_clocksource_read() - xen_sched_clock_offset; xen_clock_value_saved = xen_sched_clock() maybe? -boris

[PATCH] xen: Fix x86 sched_clock() interface for xen

2019-01-10 Thread Juergen Gross
Commit f94c8d11699759 ("sched/clock, x86/tsc: Rework the x86 'unstable' sched_clock() interface") broke Xen guest time handling across migration: [ 187.249951] Freezing user space processes ... (elapsed 0.001 seconds) done. [ 187.251137] OOM killer disabled. [ 187.251137] Freezing remaining fre