Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Dmitry Torokhov
On Wed, Dec 04, 2013 at 11:48:03AM -0500, Konrad Rzeszutek Wilk wrote: > > > which is hardly nice. This patch fixes this by having each > > > PV driver check for: > > > - if running in PV, then it is fine to execute (as that is their > > >native environment). > > > - if running in HVM, check

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Konrad Rzeszutek Wilk
> > which is hardly nice. This patch fixes this by having each > > PV driver check for: > > - if running in PV, then it is fine to execute (as that is their > >native environment). > > - if running in HVM, check if user wanted 'xen_emul_unplug=never', > >in which case bail out and don't l

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Dmitry Torokhov
Hi Konrad, On Tue, Dec 03, 2013 at 04:14:06PM -0500, Konrad Rzeszutek Wilk wrote: > The user has the option of disabling the platform driver: > 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) > > which is used to unplug the emulated drivers (IDE, Realtek 8169, etc) >

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 13:00 +, David Vrabel wrote: > On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: > > > > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' > > but unfortunatly the xen-blkfront driver is using it, so we > > cannot do it. > > I had a look at what blkfront was

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread David Vrabel
On 03/12/13 21:14, Konrad Rzeszutek Wilk wrote: > > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug' > but unfortunatly the xen-blkfront driver is using it, so we > cannot do it. I had a look at what blkfront was using this for and it seems dumb. How did we end up with the fronten

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:18 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: > > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > > > > > On Wed

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Stefano Stabellini
On Wed, 4 Dec 2013, Ian Campbell wrote: > On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > > > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > > > +bool xen_has_pv_devices(

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 11:05 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > > +bool xen_has_pv_devices(void) > > > > > +{ > > > > > + if (!xen_domain

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Stefano Stabellini
On Wed, 4 Dec 2013, Ian Campbell wrote: > On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > > +bool xen_has_pv_devices(void) > > > > +{ > > > > + if (!xen_domain()) > > > > + return false; > > > > + > > > > + if

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Wed, 2013-12-04 at 10:51 +, Stefano Stabellini wrote: > On Wed, 4 Dec 2013, Ian Campbell wrote: > > > +bool xen_has_pv_devices(void) > > > +{ > > > + if (!xen_domain()) > > > + return false; > > > + > > > + if (xen_hvm_domain()) { > > > + /* User requested no unplug, so no PV

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Stefano Stabellini
On Wed, 4 Dec 2013, Ian Campbell wrote: > > +bool xen_has_pv_devices(void) > > +{ > > + if (!xen_domain()) > > + return false; > > + > > + if (xen_hvm_domain()) { > > + /* User requested no unplug, so no PV drivers. */ > > + if (xen_emul_unplug & XEN_UNPLUG_NEVER)

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Stefano Stabellini
On Tue, 3 Dec 2013, Konrad Rzeszutek Wilk wrote: > diff --git a/arch/x86/xen/platform-pci-unplug.c > b/arch/x86/xen/platform-pci-unplug.c > index 0a78524..087dfeb 100644 > --- a/arch/x86/xen/platform-pci-unplug.c > +++ b/arch/x86/xen/platform-pci-unplug.c > @@ -69,6 +69,24 @@ static int check_plat

Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-04 Thread Ian Campbell
On Tue, 2013-12-03 at 16:14 -0500, Konrad Rzeszutek Wilk wrote: > The user has the option of disabling the platform driver: > 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) > > which is used to unplug the emulated drivers (IDE, Realtek 8169, etc) > and allow the PV d

Re: [Xen-devel] [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-03 Thread Matthew Daley
On Wed, Dec 4, 2013 at 10:14 AM, Konrad Rzeszutek Wilk wrote: > The user has the option of disabling the platform driver: > 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) > > which is used to unplug the emulated drivers (IDE, Realtek 8169, etc) > and allow the PV dri

[PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

2013-12-03 Thread Konrad Rzeszutek Wilk
The user has the option of disabling the platform driver: 00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01) which is used to unplug the emulated drivers (IDE, Realtek 8169, etc) and allow the PV drivers to take over. If the user wishes to disable that they can set: x