Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-12 Thread Joe Perches
On Fri, 2020-06-12 at 14:05 +0200, Jesper Dangaard Brouer wrote: > On Fri, 12 Jun 2020 03:14:58 -0700 > Joe Perches wrote: > > > On Fri, 2020-06-12 at 08:42 +0200, Jesper Dangaard Brouer wrote: > > > On Thu, 11 Jun 2020 20:36:40 -0400 > > > Gaurav Singh wrote: > > > > > > > Replace malloc/mem

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-12 Thread Toke Høiland-Jørgensen
Joe Perches writes: > On Fri, 2020-06-12 at 08:42 +0200, Jesper Dangaard Brouer wrote: >> On Thu, 11 Jun 2020 20:36:40 -0400 >> Gaurav Singh wrote: >> >> > Replace malloc/memset with calloc >> > >> > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to >> > xdp_rxq_info") >> > S

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-12 Thread Jesper Dangaard Brouer
On Fri, 12 Jun 2020 03:14:58 -0700 Joe Perches wrote: > On Fri, 2020-06-12 at 08:42 +0200, Jesper Dangaard Brouer wrote: > > On Thu, 11 Jun 2020 20:36:40 -0400 > > Gaurav Singh wrote: > > > > > Replace malloc/memset with calloc > > > > > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstra

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-12 Thread Joe Perches
On Fri, 2020-06-12 at 08:42 +0200, Jesper Dangaard Brouer wrote: > On Thu, 11 Jun 2020 20:36:40 -0400 > Gaurav Singh wrote: > > > Replace malloc/memset with calloc > > > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to > > xdp_rxq_info") > > Signed-off-by: Gaurav Singh > >

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Jesper Dangaard Brouer
On Thu, 11 Jun 2020 20:36:40 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc > > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to > xdp_rxq_info") > Signed-off-by: Gaurav Singh Above is the correct use of Fixes + Signed-off-by. Now you need to update/improve t

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c

Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Jesper Dangaard Brouer
On Thu, 11 Jun 2020 11:02:21 -0400 Gaurav Singh wrote: > Replace malloc/memset with calloc Please also mention/describe that this also solves the bug you found. As this fix a potential bug, it will be appropriate to add a "Fixes:" line, just before "Signed-off-by" (meaning no newline between t

[PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc

2020-06-11 Thread Gaurav Singh
Replace malloc/memset with calloc Signed-off-by: Gaurav Singh --- samples/bpf/xdp_rxq_info_user.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/samples/bpf/xdp_rxq_info_user.c b/samples/bpf/xdp_rxq_info_user.c index 4fe47502ebed..caa4e7ffcfc7 100644 --- a/sam