Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-08 Thread Andi Kleen
On Thursday 08 March 2007 19:49, Tom Rini wrote: > On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote: > > On Thursday 08 March 2007 18:44, Dave Jiang wrote: > > > > > In spite of kgdb, shouldn't it have that \n anyways in case some other > > > code > > > gets added in the future after th

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-08 Thread Tom Rini
On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote: > On Thursday 08 March 2007 18:44, Dave Jiang wrote: > > > In spite of kgdb, shouldn't it have that \n anyways in case some other code > > gets added in the future after the macro? Or are you saying that there > > should > > never be any

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-08 Thread Andi Kleen
On Thursday 08 March 2007 18:44, Dave Jiang wrote: > In spite of kgdb, shouldn't it have that \n anyways in case some other code > gets added in the future after the macro? Or are you saying that there should > never be any code ever after that macro? Sure if there is mainline code added after th

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-08 Thread Dave Jiang
Andi Kleen wrote: > On Wednesday 07 March 2007 21:45, Dave Jiang wrote: >> The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in >> the >> previous patch that touched system.h. It causes compile failure if any >> inline asm is added after the macro. Discovered this when playi

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-08 Thread Andi Kleen
On Wednesday 07 March 2007 21:45, Dave Jiang wrote: > > The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in > the > previous patch that touched system.h. It causes compile failure if any > inline asm is added after the macro. Discovered this when playing with > kgdb. We w

[PATCH] x86_64 RESTORE_CONTEXT missing '\n'

2007-03-07 Thread Dave Jiang
The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in the previous patch that touched system.h. It causes compile failure if any inline asm is added after the macro. Discovered this when playing with kgdb. Signed-off-by: Dave Jiang <[EMAIL PROTECTED]> --- include/asm-x86_