Re: [PATCH] x86_64: check if Tom2 is enabled

> > Actually, I think it depends on the specific MSR - some use the halves > for different data, whereas others treat it as a large 64-bit object. Even if there are different fields in there it is still much cleaner and simpler if there is only a single number to manipulate. > Ironically enoug

Re: [PATCH] x86_64: check if Tom2 is enabled

Cyrill Gorcunov wrote: [Andi Kleen - Mon, Jan 21, 2008 at 07:03:27PM +0100] | | > is it possible to change 'l' and 'h' to 'low' and 'high'? | > 'cause 'l' does look like '1' (one) number... | | It would be fine for me for someone to implement safe_rdtscll() and get rid | of l and h everywhere

Re: [PATCH] x86_64: check if Tom2 is enabled

[Andi Kleen - Mon, Jan 21, 2008 at 07:03:27PM +0100] | | > is it possible to change 'l' and 'h' to 'low' and 'high'? | > 'cause 'l' does look like '1' (one) number... | | It would be fine for me for someone to implement safe_rdtscll() and get rid | of l and h everywhere. IMHO all the l and h acce

Re: [PATCH] x86_64: check if Tom2 is enabled

> is it possible to change 'l' and 'h' to 'low' and 'high'? > 'cause 'l' does look like '1' (one) number... It would be fine for me for someone to implement safe_rdtscll() and get rid of l and h everywhere. IMHO all the l and h accesses of MSRs are just harder to read and error prone over the ll

Re: [PATCH] x86_64: check if Tom2 is enabled

[H. Peter Anvin - Mon, Jan 21, 2008 at 09:39:16AM -0800] > Cyrill Gorcunov wrote: >> is it possible to change 'l' and 'h' to 'low' and 'high'? >> 'cause 'l' does look like '1' (one) number... > > I think you should use a different font. Otherwise we're soon in a > position where we can't abbrevia

Re: [PATCH] x86_64: check if Tom2 is enabled

Cyrill Gorcunov wrote: is it possible to change 'l' and 'h' to 'low' and 'high'? 'cause 'l' does look like '1' (one) number... I think you should use a different font. Otherwise we're soon in a position where we can't abbreviate anything that starts with L and keep using lower case through

Re: [PATCH] x86_64: check if Tom2 is enabled

[Yinghai Lu - Sun, Jan 20, 2008 at 10:57:46PM -0800] | [PATCH] x86_64: check if Tom2 is enabled | | need to applied after andi's amd special tom2 wb check patch | | in amd_special_default_mtrr need to check if TOM2 is enabled | | Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> | | d

[PATCH] x86_64: check if Tom2 is enabled

[PATCH] x86_64: check if Tom2 is enabled need to applied after andi's amd special tom2 wb check patch in amd_special_default_mtrr need to check if TOM2 is enabled Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/m