Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 10:06 -0800, H. Peter Anvin wrote: > Ingo Molnar wrote: > > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > >>case 1: > >> - *(unsigned char *)s = pattern; > >> + *(unsigned char *)s = pattern & 0xff; > > > > i've applied your

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread H. Peter Anvin
Ingo Molnar wrote: * Harvey Harrison <[EMAIL PROTECTED]> wrote: case 1: - *(unsigned char *)s = pattern; + *(unsigned char *)s = pattern & 0xff; i've applied your fix - but wouldnt it be cleaner to just cast the pattern variable to

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 11:56 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > case 1: > > - *(unsigned char *)s = pattern; > > + *(unsigned char *)s = pattern & 0xff; > > i've applied your fix - but wouldnt it be cleaner

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > case 1: > - *(unsigned char *)s = pattern; > + *(unsigned char *)s = pattern & 0xff; i've applied your fix - but wouldnt it be cleaner to just cast the pattern variable to unsigned char instead?

[PATCH] x86: sparse errors from string_32.h

2008-01-31 Thread Harvey Harrison
include/asm/string_32.h:216:26: warning: cast truncates bits from constant value ( becomes cc) include/asm/string_32.h:219:27: warning: cast truncates bits from constant value ( becomes ) include/asm/string_32.h:222:27: warning: cast truncates bits from constant value (cc