Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread Li, Aubrey
On 2014/3/7 10:21, Joe Perches wrote: > On Fri, 2014-03-07 at 10:08 +0800, Li, Aubrey wrote: > >> The Power Management Controller (PMC) controls many of the power >> management features present in the SoC. This driver provides >> interface to configure the Power Management Controller (PMC). > > M

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread Joe Perches
On Fri, 2014-03-07 at 10:08 +0800, Li, Aubrey wrote: > The Power Management Controller (PMC) controls many of the power > management features present in the SoC. This driver provides > interface to configure the Power Management Controller (PMC). More trivial notes. Nothing really that should st

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread Li, Aubrey
On 2014/3/7 8:41, Joe Perches wrote: > On Fri, 2014-03-07 at 08:26 +0800, Li, Aubrey wrote: > >> my patch is word wrapped while I was not aware, hope this one work. > > trivial notes: > Thanks for your comments, Joe. Patch refined as below: -Aubrey [PATCH] X86 platform: New Intel Atom SOC powe

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread Joe Perches
On Fri, 2014-03-07 at 08:26 +0800, Li, Aubrey wrote: > my patch is word wrapped while I was not aware, hope this one work. trivial notes: > diff --git a/arch/x86/include/asm/pmc_atom.h b/arch/x86/include/asm/pmc_atom.h [] > +#define BIT_LPSS1_F0_DMA(1 << 0) > +#define BIT_LPSS1

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread Li, Aubrey
On 2014/3/7 0:30, H. Peter Anvin wrote: > On 03/05/2014 09:58 PM, Li, Aubrey wrote: >>> >>> What we absolutely don't want to happen is someone starting to use these >>> unstable interfaces for something other than debugging. If debugfs ever >>> needs to be mounted in a system for full functionalit

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-06 Thread H. Peter Anvin
On 03/05/2014 09:58 PM, Li, Aubrey wrote: >> >> What we absolutely don't want to happen is someone starting to use these >> unstable interfaces for something other than debugging. If debugfs ever >> needs to be mounted in a system for full functionality, that is a bug. > > Understood. But we don'

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread Li, Aubrey
On 2014/3/6 13:52, H. Peter Anvin wrote: > On 03/05/2014 09:33 PM, Li, Aubrey wrote: >> >> These interfaces are uncommitted and don't have consumers now, I'd like >> to keep them unstable in debugfs. >> >> We can change it if we received a requirement to use them later. >> > > What we absolutely d

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread H. Peter Anvin
On 03/05/2014 09:33 PM, Li, Aubrey wrote: > > These interfaces are uncommitted and don't have consumers now, I'd like > to keep them unstable in debugfs. > > We can change it if we received a requirement to use them later. > What we absolutely don't want to happen is someone starting to use the

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread Li, Aubrey
On 2014/3/6 13:28, H. Peter Anvin wrote: > On 03/05/2014 09:21 PM, Li, Aubrey wrote: >>> >>> What is the reason for putting this in debugfs? >> >> S0ix support on Atom SoC needs all of the devices under south complex to >> be quiesced, as well as the devices under north complex. This interface >> s

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread H. Peter Anvin
On 03/05/2014 09:21 PM, Li, Aubrey wrote: >> >> What is the reason for putting this in debugfs? > > S0ix support on Atom SoC needs all of the devices under south complex to > be quiesced, as well as the devices under north complex. This interface > shows all of the devices states under platform co

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread Li, Aubrey
On 2014/3/6 11:49, H. Peter Anvin wrote: > On 03/05/2014 07:31 PM, Li, Aubrey wrote: >> The Power Management Controller (PMC) controls many of the power >> management features present in the SoC. This driver provides >> interface to configure the Power Management Controller (PMC). >> >> This driver

Re: [PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread H. Peter Anvin
On 03/05/2014 07:31 PM, Li, Aubrey wrote: > The Power Management Controller (PMC) controls many of the power > management features present in the SoC. This driver provides > interface to configure the Power Management Controller (PMC). > > This driver exposes PMC device state and sleep state resid

[PATCH] x86: new Intel Atom SoC power management controller driver

2014-03-05 Thread Li, Aubrey
The Power Management Controller (PMC) controls many of the power management features present in the SoC. This driver provides interface to configure the Power Management Controller (PMC). This driver exposes PMC device state and sleep state residency via debugfs for observation: /sys/kerne