Re: [PATCH] x86: fix cpu-hotplug regression

On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2007 23:15:38 +0900 > "Akinobu Mita" <[EMAIL PROTECTED]> wrote: > > > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > > > CPU_UP_PRE

Re: [PATCH] x86: fix cpu-hotplug regression

On Wed, 7 Nov 2007 23:15:38 +0900 "Akinobu Mita" <[EMAIL PROTECTED]> wrote: > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > > CPU_UP_PREPARE) > > > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1

Re: [PATCH] x86: fix cpu-hotplug regression

> [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > CPU_UP_PREPARE) > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc > ("cpu hotplug: mce: fix cpu hotplug error handling"). > > For CPUs not broug

Re: [PATCH] x86: fix cpu-hotplug regression

uot;do mce_create_device in CPU_UP_PREPARE instead of CPU_ONLINE"). Thinking twice about the problem it seems obvious that this part of the patch should just be reverted. Attached is a new fix (diff against 2.6.24-rc2). Regards, Andreas -- [PATCH] x86: fix cpu ho

Re: [PATCH] x86: fix cpu-hotplug regression

On Wednesday 07 November 2007 02:12, Andreas Herrmann wrote: > In cases where not all CPUs are brought up during > boot (e.g. using maxcpus and additional_cpus parameters) > mce_cpu_callback now returns NOTFIY_BAD because > for such CPUs cpu_data is not completely filled when > the notifier is cal

[PATCH] x86: fix cpu-hotplug regression

[PATCH] x86: fix cpu-hotplug regression Commit d435d862baca3e25e5eec236762a43251b1e7ffc ("cpu hotplug: mce: fix cpu hotplug error handling") changed the error handling in mce_cpu_callback. In cases where not all CPUs are brought up during boot (e.g. using maxcpus and additional_cpus