Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread H. Peter Anvin
Cyrill Gorcunov wrote: Thanks Peter, my fault. No problem; this is why we do reviews :) -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread Cyrill Gorcunov
[H. Peter Anvin - Thu, Feb 21, 2008 at 11:59:28AM -0800] > Cyrill Gorcunov wrote: >> [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800] >>> Cyrill Gorcunov wrote: This patch replaces 4096 numeric constant with PAGE_SIZE macro. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread H. Peter Anvin
Cyrill Gorcunov wrote: [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800] Cyrill Gorcunov wrote: This patch replaces 4096 numeric constant with PAGE_SIZE macro. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Text segments of old and new files *are* the same so it wouldn't break cu

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread Cyrill Gorcunov
[H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800] > Cyrill Gorcunov wrote: >> This patch replaces 4096 numeric constant with PAGE_SIZE macro. >> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> >> --- >> Text segments of old and new files *are* the same so >> it wouldn't break current kern

[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread Cyrill Gorcunov
This patch replaces 4096 numeric constant with PAGE_SIZE macro. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Text segments of old and new files *are* the same so it wouldn't break current kernel. main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6.git/

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

2008-02-21 Thread H. Peter Anvin
Cyrill Gorcunov wrote: This patch replaces 4096 numeric constant with PAGE_SIZE macro. Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- Text segments of old and new files *are* the same so it wouldn't break current kernel. NAK. This is NOT PAGE_SIZE (even though the two values are coi