Re: [PATCH] x86: always use SYSCALL_DEFINE*

2018-03-14 Thread Tautschnig, Michael
Hi Dominik, > On 14 Mar 2018, at 05:48, Dominik Brodowski > wrote: > [...] > ... the ioperm change is already in mainline (did an equivalent change a > couple of days ago), but the sigreturn/rt_sigreturn changes still seem > useful. Could you send a fresh patch with just these two changes; and -

Re: [PATCH] x86: always use SYSCALL_DEFINE*

2018-03-13 Thread Dominik Brodowski
Michael, On Tue, Mar 13, 2018 at 11:18:08PM +, Andy Lutomirski wrote: > On Tue, Mar 13, 2018 at 9:16 PM, Jann Horn wrote: > > On Sat, Mar 10, 2018 at 12:55 PM, Tautschnig, Michael > > wrote: > >> All syscall arguments are passed in as types of the same byte size as > >> unsigned long (width

Re: [PATCH] x86: always use SYSCALL_DEFINE*

2018-03-13 Thread Andy Lutomirski
On Tue, Mar 13, 2018 at 9:16 PM, Jann Horn wrote: > On Sat, Mar 10, 2018 at 12:55 PM, Tautschnig, Michael > wrote: >> All syscall arguments are passed in as types of the same byte size as >> unsigned long (width of full registers). Using a smaller type without a >> cast may result in losing bits

Re: [PATCH] x86: always use SYSCALL_DEFINE*

2018-03-13 Thread Jann Horn
On Sat, Mar 10, 2018 at 12:55 PM, Tautschnig, Michael wrote: > All syscall arguments are passed in as types of the same byte size as > unsigned long (width of full registers). Using a smaller type without a > cast may result in losing bits of information. SYSCALL_DEFINE* introduce > adequate type

Re: [PATCH] x86: always use SYSCALL_DEFINE*

2018-03-10 Thread Tautschnig, Michael
On 10 Mar 2018, at 20:55, Tautschnig, Michael wrote: > > All syscall arguments are passed in as types of the same byte size as > unsigned long (width of full registers). Using a smaller type without a > cast may result in losing bits of information. SYSCALL_DEFINE* introduce > adequate type casts

[PATCH] x86: always use SYSCALL_DEFINE*

2018-03-10 Thread Tautschnig, Michael
All syscall arguments are passed in as types of the same byte size as unsigned long (width of full registers). Using a smaller type without a cast may result in losing bits of information. SYSCALL_DEFINE* introduce adequate type casts. All definitions of syscalls in x86 except for those patched her