Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-03 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > Currently the notify_page_fault helper is used to test it the page > fault was caused by a kprobe causing an early return from > do_page_fault. > > Change the name of the helper to is_kprobe_fault to match the usage > and remove the preempt_disab

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Masami Hiramatsu
Harvey Harrison wrote: > On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote: >> Hi Harvey, >> >> Harvey Harrison wrote: >>> Currently the notify_page_fault helper is used to test it the page >>> fault was caused by a kprobe causing an early return from do_page_fault. >>> >>> Change the name

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Harvey Harrison
On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote: > Hi Harvey, > > Harvey Harrison wrote: > > Currently the notify_page_fault helper is used to test it the page > > fault was caused by a kprobe causing an early return from do_page_fault. > > > > Change the name of the helper to is_kprobe

Re: [PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Masami Hiramatsu
Hi Harvey, Harvey Harrison wrote: > Currently the notify_page_fault helper is used to test it the page > fault was caused by a kprobe causing an early return from do_page_fault. > > Change the name of the helper to is_kprobe_fault to match the usage and > remove the preempt_disable/enable pair ar

[PATCH] x86: Use is_kprobe_fault to better match usage

2008-01-02 Thread Harvey Harrison
Currently the notify_page_fault helper is used to test it the page fault was caused by a kprobe causing an early return from do_page_fault. Change the name of the helper to is_kprobe_fault to match the usage and remove the preempt_disable/enable pair around kprobe_running() with an explicit test f