Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2017-02-13 Thread Borislav Petkov
On Sun, Feb 12, 2017 at 11:20:07PM -0500, Jérémy Lefaure wrote: > I am not an expert in linux patch process but I think that as Kirill > wrote the patch, he should be the author of the patch and me I should > be in the "Reported-by" tag, isn't it ? It sounds to me like he doesn't care all that muc

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2017-02-12 Thread Jérémy Lefaure
On Sun, 12 Feb 2017 15:01:55 +0100 Borislav Petkov wrote: > On Fri, Dec 16, 2016 at 11:19:16PM -0500, Jérémy Lefaure wrote: > > I don't know why gcc raises a warning on that even if it is not used. > > Anyway, I'm sure that the warning is reproducible. Both of your > > solutions fix the issue.

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2017-02-12 Thread Borislav Petkov
On Fri, Dec 16, 2016 at 11:19:16PM -0500, Jérémy Lefaure wrote: > I don't know why gcc raises a warning on that even if it is not used. > Anyway, I'm sure that the warning is reproducible. Both of your > solutions fix the issue. I still see the warning here. You wanna choose one solution, write a

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-16 Thread Jérémy Lefaure
On Mon, 12 Dec 2016 17:52:50 +0300 "Kirill A. Shutemov" wrote: > On Thu, Dec 08, 2016 at 01:25:37PM -0500, Jérémy Lefaure wrote: > > On Thu, 8 Dec 2016 13:50:11 +0300 > > "Kirill A. Shutemov" wrote: > > > > > On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > > > > When CONFI

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-12 Thread Kirill A. Shutemov
On Thu, Dec 08, 2016 at 01:25:37PM -0500, Jérémy Lefaure wrote: > On Thu, 8 Dec 2016 13:50:11 +0300 > "Kirill A. Shutemov" wrote: > > > On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > > > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > > > stub. In such

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-08 Thread Jérémy Lefaure
On Thu, 8 Dec 2016 13:50:11 +0300 "Kirill A. Shutemov" wrote: > On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > > stub. In such case, vma is unused and a compiler raises a warning: > > > > arch/x86/kern

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-08 Thread Jérémy Lefaure
On Thu, 8 Dec 2016 09:33:05 +0100 Borislav Petkov wrote: > On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > > stub. In such case, vma is unused and a compiler raises a warning: > > > > arch/x86/kernel/vm

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-08 Thread Kirill A. Shutemov
On Thu, Dec 08, 2016 at 01:50:11PM +0300, Kirill A. Shutemov wrote: > On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > > stub. In such case, vma is unused and a compiler raises a warning: > > > > arch/x86/

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-08 Thread Kirill A. Shutemov
On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > stub. In such case, vma is unused and a compiler raises a warning: > > arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’: > arch/x86/kernel/vm86_32.

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-08 Thread Borislav Petkov
On Wed, Dec 07, 2016 at 11:38:33PM -0500, Jérémy Lefaure wrote: > When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op > stub. In such case, vma is unused and a compiler raises a warning: > > arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’: > arch/x86/kernel/vm86_32.

[PATCH] x86/vm86: fix compilation warning on a unused variable

2016-12-07 Thread Jérémy Lefaure
When CONFIG_TRANSPARENT_HUGEPAGE is disabled, split_huge_pmd is a no-op stub. In such case, vma is unused and a compiler raises a warning: arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’: arch/x86/kernel/vm86_32.c:180:26: warning: unused variable ‘vma’ [-Wunused-variable] struct vm_