Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-03-27 Thread Borislav Petkov
On Sun, Mar 03, 2019 at 10:47:00PM -0800, Christian Kujau wrote: > If so, would simly removing it do the trick or is there more magic > involved? I don't have that many cross-compilers though and it's not even > build-tested: There are cross compilers here: https://www.kernel.org/pub/tools/cros

Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-03-03 Thread Christian Kujau
On Mon, 25 Feb 2019, Joe Perches wrote: > Looks like it's not used in several arches > > $ git grep -w __addr_ok > arch/arm/include/asm/uaccess.h:#define __addr_ok(addr) > ((void)(addr), 1) > arch/csky/include/asm/uaccess.h:#define __addr_ok(addr) (access_ok(addr, 0)) > arch/openrisc/inc

Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-02-25 Thread Joe Perches
On Mon, 2019-02-25 at 20:42 +0100, Borislav Petkov wrote: > On Mon, Feb 25, 2019 at 11:20:42AM -0800, Linus Torvalds wrote: > > On Mon, Feb 25, 2019 at 11:11 AM Borislav Petkov wrote: > > > This was caught while staring at the whole {set,get}_fs() machinery. > > > > Heh. > > > > You should proba

Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-02-25 Thread Borislav Petkov
On Mon, Feb 25, 2019 at 11:20:42AM -0800, Linus Torvalds wrote: > On Mon, Feb 25, 2019 at 11:11 AM Borislav Petkov wrote: > > > > This was caught while staring at the whole {set,get}_fs() machinery. > > Heh. > > You should probably have researched _when_ it became unused. > > That seems to have

Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-02-25 Thread Linus Torvalds
On Mon, Feb 25, 2019 at 11:11 AM Borislav Petkov wrote: > > This was caught while staring at the whole {set,get}_fs() machinery. Heh. You should probably have researched _when_ it became unused. That seems to have happened in commit 5723aa993d83 ("x86: use the new generic strnlen_user() functio

[PATCH] x86/uaccess: Remove unused __addr_ok() macro

2019-02-25 Thread Borislav Petkov
From: Borislav Petkov This was caught while staring at the whole {set,get}_fs() machinery. No functional changes. Signed-off-by: Borislav Petkov Cc: Andy Lutomirski Cc: Jann Horn Cc: Linus Torvalds Cc: Peter Zijlstra Cc: the arch/x86 maintainers Cc: "Tobin C. Harding" --- arch/x86/inclu