Re: [PATCH] x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386

2019-08-23 Thread Peter Zijlstra
On Thu, Aug 22, 2019 at 02:11:22PM -0700, Sean Christopherson wrote: > Use 'lea' instead of 'add' when adjusting %rsp in CALL_NOSPEC so as to > avoid clobbering flags. > > KVM's emulator makes indirect calls into a jump table of sorts, where > the destination of the CALL_NOSPEC is a small blob of

[PATCH] x86/retpoline: Don't clobber RFLAGS during CALL_NOSPEC on i386

2019-08-22 Thread Sean Christopherson
Use 'lea' instead of 'add' when adjusting %rsp in CALL_NOSPEC so as to avoid clobbering flags. KVM's emulator makes indirect calls into a jump table of sorts, where the destination of the CALL_NOSPEC is a small blob of code that performs fast emulation by executing the target instruction with fixe