Re: [PATCH] x86/power/64: Remove VLA usage

2018-07-18 Thread Kees Cook
On Mon, Jul 16, 2018 at 10:22 AM, Eric Biggers wrote: > On Sun, Jul 15, 2018 at 08:56:57PM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to >> shash directly and allocating the de

Re: [PATCH] x86/power/64: Remove VLA usage

2018-07-16 Thread Eric Biggers
On Sun, Jul 15, 2018 at 08:56:57PM -0700, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has

Re: [PATCH] x86/power/64: Remove VLA usage

2018-07-16 Thread Pavel Machek
On Sun 2018-07-15 20:56:57, Kees Cook wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > shash directly and allocating the descriptor in heap memory (which should > be fine: the tfm has already been

[PATCH] x86/power/64: Remove VLA usage

2018-07-15 Thread Kees Cook
In the quest to remove all stack VLA usage from the kernel[1], this removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to shash directly and allocating the descriptor in heap memory (which should be fine: the tfm has already been allocated there too). [1] https://lkml.kernel.org/r