Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

On 2015/8/12 2:52, Luck, Tony wrote: Well, ok, but do it differently, please: rename cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which turns them on and off. Unless Tony has a better suggestion... I like the boolean argument ... but not the "switch_banks" name. It sounds more

Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

On 2015/8/11 22:46, Borislav Petkov wrote: On Tue, Aug 11, 2015 at 06:09:37PM +0800, Xie XiuQi wrote: Zhang Liguang report a bug as bellow: 1) system detected cmci storm on current cpu 2) disable cmci interrupt on banks ownd by current cpu, then swiching to poll mode 3) a few minites later, sys

RE: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

> Well, ok, but do it differently, please: rename > cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which > turns them on and off. Unless Tony has a better suggestion... I like the boolean argument ... but not the "switch_banks" name. It sounds more like we are juggling between bank

Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

On Tue, Aug 11, 2015 at 06:09:37PM +0800, Xie XiuQi wrote: > Zhang Liguang report a bug as bellow: > 1) system detected cmci storm on current cpu > 2) disable cmci interrupt on banks ownd by current cpu, then swiching to poll > mode > 3) a few minites later, system swiching to interrupt mode on cu

[PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

Zhang Liguang report a bug as bellow: 1) system detected cmci storm on current cpu 2) disable cmci interrupt on banks ownd by current cpu, then swiching to poll mode 3) a few minites later, system swiching to interrupt mode on current cpu 4) we expect system to reenable cmci interrupt on banks own