Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-26 Thread Lenny Szubowicz
On 3/26/21 9:01 AM, Vitaly Kuznetsov wrote: Vitaly Kuznetsov writes: .. (this is with your v2 included). There's nothing about CPU0 for e.g. async PF + timestamps are really interesting. Seems we have issues to fix) I'm playing with it right now. What if we do the following (instead of your

Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-26 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: .. > (this is with your v2 included). There's nothing about CPU0 for > e.g. async PF + timestamps are really interesting. Seems we have issues > to fix) I'm playing with it right now. What if we do the following (instead of your patch): diff --git a/arch/x86/kernel/kvm

Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-26 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Lenny Szubowicz writes: > >> On 3/17/21 9:30 AM, Vitaly Kuznetsov wrote: >>> Lenny Szubowicz writes: >>> Turn off host updates to the registered kvmclock memory locations when transitioning to a hibernated kernel in resume_target_kernel(). Th

Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-26 Thread Vitaly Kuznetsov
Lenny Szubowicz writes: > On 3/17/21 9:30 AM, Vitaly Kuznetsov wrote: >> Lenny Szubowicz writes: >> >>> Turn off host updates to the registered kvmclock memory >>> locations when transitioning to a hibernated kernel in >>> resume_target_kernel(). >>> >>> This is accomplished for secondary vcpus

Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-25 Thread Lenny Szubowicz
On 3/17/21 9:30 AM, Vitaly Kuznetsov wrote: Lenny Szubowicz writes: Turn off host updates to the registered kvmclock memory locations when transitioning to a hibernated kernel in resume_target_kernel(). This is accomplished for secondary vcpus by disabling host clock updates for that vcpu whe

Re: [PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-17 Thread Vitaly Kuznetsov
Lenny Szubowicz writes: > Turn off host updates to the registered kvmclock memory > locations when transitioning to a hibernated kernel in > resume_target_kernel(). > > This is accomplished for secondary vcpus by disabling host > clock updates for that vcpu when it is put offline. For the > prima

[PATCH] x86/kvmclock: Stop kvmclocks for hibernate restore

2021-03-11 Thread Lenny Szubowicz
Turn off host updates to the registered kvmclock memory locations when transitioning to a hibernated kernel in resume_target_kernel(). This is accomplished for secondary vcpus by disabling host clock updates for that vcpu when it is put offline. For the primary vcpu, it's accomplished by using the