Re: [PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

2018-05-05 Thread Joey Pabalinas
On Thu, Mar 29, 2018 at 11:41:20PM +0200, Radim Krčmář wrote: > I remember we had a bug where tasks were getting stuck when running > nested and maybe there are going to be other cases to excuse the change. > I'm slightly against changing the behavior as it's pretty hard to test, > but I can be eas

Re: [PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

2018-03-29 Thread Radim Krčmář
2018-03-16 00:57-1000, Joey Pabalinas: > There doesn't seem to be any advantage to having a *completely* > uninterruptible task here. For most users, allowing a task to respond > to the SIGKILL interrupt signal (all other signals are ignored just like > TASK_UNINTERRUPTIBLE) will not impact them at

[PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

2018-03-16 Thread Joey Pabalinas
There doesn't seem to be any advantage to having a *completely* uninterruptible task here. For most users, allowing a task to respond to the SIGKILL interrupt signal (all other signals are ignored just like TASK_UNINTERRUPTIBLE) will not impact them at all. However, for the rare edge-cases where a