Re: [PATCH] x86/kprobes: Remove dead code

2021-03-24 Thread Masami Hiramatsu
On Thu, 25 Mar 2021 07:56:54 +0900 Masami Hiramatsu wrote: > On Wed, 24 Mar 2021 17:50:16 + > Colin Ian King wrote: > > > On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > > > The condition in switch statement `opcode & 0xf0` cannot evaluate to > > > 0xff. So this case statement will never

Re: [PATCH] x86/kprobes: Remove dead code

2021-03-24 Thread Masami Hiramatsu
On Wed, 24 Mar 2021 17:50:16 + Colin Ian King wrote: > On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > > The condition in switch statement `opcode & 0xf0` cannot evaluate to > > 0xff. So this case statement will never execute. Remove it. > > > > Fixes: 6256e668b7 ("x86/kprobes: Use int3 i

Re: [PATCH] x86/kprobes: Remove dead code

2021-03-24 Thread Colin Ian King
On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > The condition in switch statement `opcode & 0xf0` cannot evaluate to > 0xff. So this case statement will never execute. Remove it. > > Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for > single-step") > Signed-off-by: Muhammad U

[PATCH] x86/kprobes: Remove dead code

2021-03-24 Thread Muhammad Usama Anjum
The condition in switch statement `opcode & 0xf0` cannot evaluate to 0xff. So this case statement will never execute. Remove it. Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for single-step") Signed-off-by: Muhammad Usama Anjum --- arch/x86/kernel/kprobes/core.c | 3 --- 1 fi